Trim single quotes from sheet names to fix calculation engine resolve references failed #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2253 +/- ##
========================================
Coverage 99.55% 99.56%
========================================
Files 32 32
Lines 25778 26291 +513
========================================
+ Hits 25663 26176 +513
Misses 60 60
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jpoz
force-pushed
the
jpoz/fix-special-chars-in-sheetnames
branch
from
6506c4b to
ccd825c
Compare
Excel wraps sheet names containing spaces or special characters in single quotes. The calculation engine previously failed to resolve these references because it included literal quotes in the sheet lookup. Strip surrounding quotes during parsing to ensure formulas correctly resolve data across sheets with spaces, hyphens, or other special characters.
jpoz
force-pushed
the
jpoz/fix-special-chars-in-sheetnames
branch
from
ccd825c to
63bc6f3
Compare
xuri
added
the
size/L
…est case into TestCalcWithDefinedName - Remove TestCalcWithNamedRangesVariousScenarios because the changes of calc.go already covered by TestCalcWithDefinedName
xuri
added
size/S
xuri
approved these changes
Jan 26, 2026
Member
xuri
left a comment
xuri
left a comment
There was a problem hiding this comment.
Great work! Thanks for your contribution.
xuri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Excel wraps sheet names containing spaces or special characters in single quotes. The calculation engine previously failed to resolve these references because it included literal quotes in the sheet lookup.
Description
In this PR we strip surrounding quotes during parsing to ensure formulas correctly resolve data across sheets with spaces, hyphens, or other special characters.
How Has This Been Tested
Added test coverage
Types of changes
Checklist