Skip to content

Add support for ArrayParameter in DoNds #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions qdev_wrappers/dataset/doNd.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
import matplotlib
import matplotlib.pyplot as plt

from qcodes.instrument.parameter import (
_BaseParameter, ArrayParameter, MultiParameter)
from qcodes.dataset.measurements import Measurement, res_type, DataSaver
from qcodes.instrument.base import _BaseParameter
from qcodes.dataset.plotting import plot_by_id
from qcodes import config

Expand Down Expand Up @@ -39,9 +40,18 @@ def _register_parameters(
setpoints: Optional[List[_BaseParameter]] = None
) -> None:
for parameter in param_meas:
if isinstance(parameter, _BaseParameter):
meas.register_parameter(parameter,
setpoints=setpoints)
if not isinstance(parameter, _BaseParameter):
continue

if isinstance(parameter, (ArrayParameter, MultiParameter)):
paramtype = 'array'
else:
paramtype = 'numeric'

meas.register_parameter(
parameter,
paramtype=paramtype,
setpoints = setpoints)


def _register_actions(
Expand Down