-
Notifications
You must be signed in to change notification settings - Fork 27
Features/theme grid dark pr4 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azkurban
wants to merge
12
commits into
qgrid:master
Choose a base branch
from
azkurban:features/theme-grid-dark-pr4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fbc3416
Dark Theme: applied to Pager Target
5ba58f0
Merge branch 'master' of https://github.com/qgrid/ng2 into features/t…
4e2c5dd
Dark Theme: applied to cell editors
c25a540
dark theme: applied to datepicker Calendar control
6f82c91
Merge branch 'master' of https://github.com/qgrid/ng2 into features/t…
6ac27bf
Merge branch 'master' of https://github.com/qgrid/ng2 into features/t…
bc33fef
panelClass+q-grid-theme-overlay behavior research + refactoring
e54ee62
refactoring: removed pager.theme property & got rid of mat-select pa…
f4f462c
Merge branch 'master' of https://github.com/qgrid/ng2 into features/t…
f1b8f92
Gramma error fix
e36d4b7
Merge branch 'master' of https://github.com/qgrid/ng2 into features/t…
b877f0f
minor refactoring
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
src/examples/theme-grid-dark/example-theme-grid-dark.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| <q-grid caption="Look People" class="q-grid-dark" | ||
| [rows]="rows | async"> | ||
| <q-grid caption="Look People" | ||
| class="q-grid-dark" | ||
| [rows]="rows | async" | ||
| editMode="cell"> | ||
| <q-grid-columns generation="deep"> | ||
| </q-grid-columns> | ||
| </q-grid> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |
| <mat-datepicker-toggle matSuffix | ||
| [for]="picker"> | ||
| </mat-datepicker-toggle> | ||
| <mat-datepicker #picker> | ||
| <mat-datepicker #picker [panelClass]="$view.edit.cell.theme"> | ||
|
||
| </mat-datepicker> | ||
| </mat-form-field> | ||
| </ng-template> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not allowed to make it here