ScrollService #344

munkk · 2018-07-30T09:52:09Z

No description provided.

klumba12 · 2018-07-30T13:00:15Z

src/core/scroll/scroll.service.js

+import { AppError } from '../infrastructure/error';
+import { jobLine } from '../services/job.line';
+
+const OFFSET = 50;


add this properties under the scroll.model

klumba12 · 2018-07-30T13:02:43Z

src/lib/main/core/body/body-core.component.ts

 		const table = this.$table;
-		const ctrl = new BodyCtrl(model, view, this.root.table, this.root.bag);
+		const scrollService = new ScrollService(model, this.root.table);
+		const ctrl = new BodyCtrl(model, view, scrollService, this.root.table, this.root.bag);


instantiate scrollService inside the BodyCtrl

klumba12 · 2018-07-30T13:04:38Z

src/core/scroll/scroll.service.js

+const VELOCITY = 5;
+
+export class ScrollService extends Disposable {
+    constructor(model, table) {


disposable service is not good practice, move all disposables outside of the service and body ctrl

klumba12 · 2018-07-30T13:05:24Z

src/core/scroll/scroll.service.js

+    }
+
+    doScroll(direction) {
+        const scrollState = this.model.scroll;


const {scroll} = this.model;

klumba12 · 2018-08-06T10:48:19Z

src/core/body/body.ctrl.d.ts

 export declare class BodyCtrl {
 	constructor(model: Model, view: any, table: Table, bag: any);

+	scrollService: ScrollService;


hide this property

klumba12 · 2018-08-06T10:48:37Z

src/core/body/body.ctrl.js

 import { Fastdom } from '../services/fastdom';
 import { GRID_PREFIX } from '../definition';
 import { jobLine } from '../services/job.line';
+import { ScrollService } from 'ng2-qgrid/core/scroll/scroll.service';


dont use ng2-qgrid in core use relative path

klumba12 · 2018-08-06T10:49:27Z

src/core/scroll/scroll.service.js

+    }
+
+    canScroll(e) {
+        const table = this.rect;


just call it rect: const {rect, offset} = this;

klumba12 · 2018-08-28T12:35:54Z

src/core/scroll/scroll.service.d.ts

+export declare class ScrollService {
+    constructor(model: Model, table: Table);
+
+    stop(): void;


add scroll method

klumba12 · 2018-08-28T12:36:24Z

src/core/scroll/scroll.service.js

+            e.clientX < (table.right - offset))
+    }
+
+    scroll(e, startCell) {


rename to start

klumba12 · 2018-08-28T12:36:39Z

src/core/scroll/scroll.service.js

+
+    }
+
+    doScroll(direction) {


rename to croll

klumba12 · 2018-08-28T12:39:19Z

src/core/scroll/scroll.service.js

+        const table = this.rect;
+        const offset = this.offset;
+
+        return !(e.clientY < (table.bottom - offset) &&


split this to var defs:
const is... =

klumba12 · 2018-08-28T12:40:54Z

src/core/scroll/scroll.service.js

+        const { velocity }  = scrollState;
+        const scrolledToEnd = () => this.isScrolledToEnd(direction);
+
+        return () => setInterval(() => {


try to use job

setInterval is located in function, which is already wrapped in Job.

this is to tricky, we need to make own interval like a jobLine, or emulate it with job

klumba12 · 2018-08-28T12:43:37Z

src/core/scroll/scroll.service.js

+        this.view = view;
+        this.interval = null;
+        this.rect = null;
+        this.body = null;


use this.markup.body directly

markup is not available during the ScrollService initialization

klumba12 · 2018-08-28T12:47:48Z

src/lib/main/core/body/body-core.component.ts

 		listener.on('mousedown', ctrl.onMouseDown.bind(ctrl));
-		listener.on('mouseup', ctrl.onMouseUp.bind(ctrl));
+
+		windowListener.on('resize', () => ctrl.resize());


Investigate if it could be run outsize ng zone

klumba12 · 2018-08-28T12:48:08Z

src/core/scroll/scroll.service.js

+    get offset() {
+        return this.model.scroll().offset;
+    }
+}


Write unit tests

klumba12 · 2018-09-07T14:07:49Z

src/core/scroll/scroll.service.js

+        model.scrollChanged.watch(e => {
+            if (this.interval) {              
+                const path = this.getPath(this.mouseEvent);
+                const td = pathFinder.cell(path);


could it be that we do not find td?

klumba12 · 2018-09-07T14:08:50Z

src/core/scroll/scroll.service.js

+        const offset = this.offset;
+
+        // check if mouse is not in areas which fire scrolling
+        const mouseNotOnTopSide = e.clientY > (rect.top + offset);


could me make positive booleans? like cursorIsOnTop?

klumba12 · 2018-09-07T14:09:25Z

src/core/scroll/scroll.service.js

+    }
+
+    start(e, startCell) {
+        this.mouseEvent = e;


could we calculate td here? not in scrollChanged event

klumba12 · 2018-09-07T14:09:55Z

src/core/scroll/scroll.service.js

+        this.mouseEvent = e;
+        this.startCell = startCell; 
+
+        if (this.interval) {


how it could happen on start?

klumba12 · 2018-09-07T14:10:53Z

src/core/scroll/scroll.service.js

+        if (direction && !this.interval) {
+            this.job(() => {
+                const interval = this.scroll(direction);
+                this.interval = interval();


could we emulate interval with jobs?

klumba12 · 2018-09-07T14:11:46Z

src/core/scroll/scroll.service.js

+        const { velocity }  = scrollState;
+        const scrolledToEnd = () => this.isScrolledToEnd(direction);
+
+        return () => setInterval(() => {


this is to tricky, we need to make own interval like a jobLine, or emulate it with job

munkk added 3 commits July 30, 2018 12:56

ScrollService

0f2713e

fix_velosity

1c83c89

fix_formatting

6c734e4

klumba12 reviewed Jul 30, 2018

View reviewed changes

ref.

4496701

munkk force-pushed the ScrollServiceN branch from 8afd08a to 758ca97 Compare July 30, 2018 16:21

munkk added 4 commits July 30, 2018 19:25

ref.

758ca97

fix_batch

35c0ae0

add_ability_to_select_cells_whithout_mousemove

2ad0db8

fix_guard_null_exeption

07397f9

munkk force-pushed the ScrollServiceN branch from 355da74 to 12094ab Compare August 2, 2018 09:07

munkk added 3 commits August 2, 2018 12:07

fix_cooment+remove_imports

12094ab

remove_import

a8d03cb

move_resizeF_invocation_from_body-core-comp_to_body.ctrl

16281de

munkk force-pushed the ScrollServiceN branch from 5def612 to 16281de Compare August 6, 2018 12:50

add_window_provider

64d046c

munkk force-pushed the ScrollServiceN branch from 9e0c73d to 64d046c Compare August 6, 2018 16:31

remove_import

039d931

munkk force-pushed the ScrollServiceN branch from 2774f49 to 039d931 Compare August 6, 2018 16:34

ref.

50e16a2

munkk force-pushed the ScrollServiceN branch from d267133 to 50e16a2 Compare August 28, 2018 11:40

klumba12 reviewed Aug 28, 2018

View reviewed changes

munkk added 4 commits August 28, 2018 16:11

ref.

b1793af

ref

d5c271b

ref

4b0c891

ref

8b853fa

klumba12 reviewed Sep 7, 2018

View reviewed changes

munkk added 2 commits September 18, 2018 16:44

refactoring

590b200

refactoring

43e4f76

munkk added 2 commits September 20, 2018 14:04

ю

a7dc051

Interval to Timeout

e0bee6f

ScrollService #344

Are you sure you want to change the base?

ScrollService #344

Uh oh!

Conversation

munkk commented Jul 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klumba12 Aug 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

klumba12 Aug 6, 2018 •

edited

Loading