Validation custom

src/core/edit/edit.cell.view.js

@@ -5,7 +5,7 @@ import { CellEditor } from './edit.cell.editor';
 import { getFactory as valueFactory } from '../services/value';
 import { getFactory as labelFactory } from '../services/label';
 import { parseFactory } from '../services/convert';
-import * as validationService from '../validation/validation.service';
+import { ValidatorBuilder } from '../validation/validator.builder';
 
 // do not delete this importing it's required in the bundle
 // TODO: investigate how to avoid it
@@ -151,7 +151,8 @@ export class EditCellView {
 					if (canEdit) {
 						const context = this.contextFactory(cell, this.value, this.label, this.tag);
 						const key = context.column.key;
-						const validator = validationService.createValidator(model.validation().rules, key);
+						const validatorBuilder = new ValidatorBuilder(model.validation().rules, key);
+						const { validator } = validatorBuilder;
 						return model.edit().commit.canExecute(context) && validator.validate({ [key]: this.value });
 					}
 					return false;
@@ -186,7 +187,8 @@ export class EditCellView {
 					if (canEdit) {
 						const context = this.contextFactory(cell, this.value, this.label, this.tag);
 						const key = context.column.key;
-						const validator = validationService.createValidator(model.validation().rules, key);
+						const validatorBuilder = new ValidatorBuilder(model.validation().rules, key);
+						const { validator } = validatorBuilder;
 						return model.edit().commit.canExecute(context) && validator.validate({ [key]: this.value });
 					}
 

src/core/validation/validator.builder.d.ts

@@ -0,0 +1,15 @@
+export declare interface Validator {
+	validate(value: any): boolean;
+	getErrors(): Array<string>;
+}
+
+export declare interface ValidatorBuilder {
+	validator: Validator;
+	fetch: () => void;
+	hasCommonRules: boolean;
+	hasCustomRules: boolean;
+	registerRules(rules: any, key: string): void;
+	hasRules(): boolean;
+}
+
+export declare function createValidator(rules: any): Validator;

src/core/validation/validator.builder.js

@@ -0,0 +1,55 @@
+import * as LIVR from 'livr';
+import { Fetch } from '../infrastructure/fetch';
+
+export const { Validator: LivrValidator } = LIVR;
+
+export function createValidator(rules) {
+	return new LivrValidator(rules);
+}
+
+export class ValidatorBuilder {
+	constructor(rules, key) {
+		this.validator = null;
+		this.hasCommonRules = false;
+		this.hasCustomRules = false;
+		this.fetch = this.fetchFactory();
+
+		this.registerRules(rules, key);
+	}
+
+	registerRules(srcRules, key) {
+		const rules = [];
+		const keyRules = srcRules.filter(r => r.key === key);
+		keyRules.forEach(rule => {
+			for (let name of Object.keys(rule)) {
+				if (name === 'test') {
+					this.customRule = {[key]: rule[name]};
+					this.hasCustomRules = true;
+				}
+				if (!['for', 'key'].includes(name)) {
+					rules.push({
+						[name]: rule[name]
+					});
+				}
+			}
+		});
+
+		this.hasCommonRules = rules.length > 0;
+		const livrRules = this.hasCommonRules ? {[key]: rules} : {};
+		this.validator = new LivrValidator(livrRules);
+		if (this.hasCustomRules) {
+			this.validator.registerRules({
+				test:() => this.customRule[key]
+			})
+		}
+	}
+
+	fetchFactory() {
+		return new Fetch(this.validator);
+	}
+
+	get hasRules() {
+		return this.hasCommonRules || this.hasCustomRules;
+	}
+
+}

src/examples/validation-basic/example-validation-basic.component.html

@@ -29,6 +29,9 @@
 		<q-grid-column key="source"
 					   title="Url">
 		</q-grid-column>
+		<q-grid-column key="discoveredIn"
+					   title="Should be > 1800 and even">
+		</q-grid-column>
 	</q-grid-columns>
 	<q-grid-validation>
 		<q-grid-rule for="cell"
@@ -73,6 +76,10 @@
 					 key="source"
 					 url>
 		</q-grid-rule>
+		<q-grid-rule for="cell"
+					 key="discoveredIn"
+					 [test]="checkNumber">
+		</q-grid-rule>
 	</q-grid-validation>
 
 </q-grid>

src/examples/validation-basic/example-validation-basic.component.ts

@@ -19,4 +19,11 @@ export class ExampleValidationBasicComponent {
 	constructor(dataService: DataService) {
 		this.rows = dataService.getAtoms();
 	}
+
+	checkNumber(v) {
+		const isValid = v > 1800 && v % 2 === 0;
+		if (!isValid) {
+			return 'Should be > 1800 and even';
+		}
+	}
 }

src/lib/infrastructure/component/model.component.ts

@@ -11,6 +11,7 @@ export class ModelComponent extends NgComponent implements OnChanges, OnInit, On
 	binder = new ModelBinder(this);
 	commit = noop;
 
+
 	constructor(public root: RootService) {
 		super();
 	}

src/lib/plugins/query-builder/schema/validator.ts

@@ -2,7 +2,7 @@ import { Injectable } from '@angular/core';
 import { AppError } from 'ng2-qgrid/core/infrastructure/error';
 import { isArray } from 'ng2-qgrid/core/utility/kit';
 import { Column, QueryBuilderService, ColumnMap } from '../query-builder.service';
-import { createValidator } from 'ng2-qgrid/core/validation/validation.service';
+import { createValidator } from 'ng2-qgrid/core/validation/validator.builder';
 
 export class Validator {
 	private columnMap: ColumnMap;

src/lib/plugins/validation/rule.component.ts

@@ -11,6 +11,9 @@ export class RuleComponent implements OnChanges {
 	@Input() for: string;
 	@Input() key: string;
 
+	// Custom validation rules
+	@Input() test?: Function;
+
 	// Common Rules
 	@Input() required?: string;
 	@Input('notEmptyList') not_empty_list?: string;
@@ -51,7 +54,7 @@ export class RuleComponent implements OnChanges {
 		private plugin: PluginService,
 		private templateHost: TemplateHostService
 	) {
-		this.templateHost.key = () => `rule`;
+		this.templateHost.key = () => 'rule';
 	}
 
 	ngOnChanges(changes: SimpleChanges) {

src/lib/plugins/validation/validator.component.ts

@@ -18,7 +18,7 @@ export class ValidatorComponent implements OnInit {
 		private plugin: PluginService,
 		private templateHost: TemplateHostService
 	) {
-		this.templateHost.key = () => `validator`;
+		this.templateHost.key = () => 'validator';
 	}
 
 	ngOnInit() {

src/plugin/validation/validator.view.d.ts

@@ -1,5 +1,5 @@
 import { Model } from '../../core/infrastructure/model';
-import { Validator } from '../../core/validation/validation.service';
+import { Validator } from '../../core/validation/validator.builder';
 
 export declare class ValidatorView {
 	constructor(model: Model, context: any);

src/plugin/validation/validator.view.js

@@ -1,15 +1,14 @@
 import { isString, isEqual } from '../../core/utility/kit';
-import { hasRules, createValidator } from '../../core/validation/validation.service';
+import { ValidatorBuilder } from '../../core/validation/validator.builder';
 
 export class ValidatorView {
 	constructor(model, context) {
 		this.model = model;
 		this.context = context;
 
 		this.oldErrors = [];
-		if (hasRules(this.rules, this.key)) {
-			this.validator = createValidator(this.rules, this.key);
-		}
+		const validatorBuilder = new ValidatorBuilder(this.rules, this.key);
+		this.validator = validatorBuilder.validator;
 	}
 
 	get errors() {