Skip to content

feature/ts-strict/qgrid-core #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FinalButterfly wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feature/ts-strict/qgrid-core #615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea2e64f
feature/ts-strict/qgrid-core
FinalButterfly May 18, 2022
24b4293
Comment corrections, first pass
FinalButterfly Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/qgrid-core/src/body/body.host.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { GridPlugin } from '../plugin/grid.plugin';
export declare class BodyHost {
constructor(plugin: GridPlugin);

scroll(e: { scrollLeft: number; scrollTop: number });
wheel(e: WheelEvent);
scroll(e: { scrollLeft: number; scrollTop: number }): void;
wheel(e: WheelEvent): void;

mouseLeave(e: MouseEvent);
mouseLeave(e: MouseEvent): void;
}
2 changes: 1 addition & 1 deletion packages/qgrid-core/src/column-list/column.list.host.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ export declare class ColumnListHost {
register(column: ColumnModel): void;
generateKey(source: any): string;
extract(key: string, type: string): ColumnModel;
delete(key: string);
delete(key: string): void;
}
2 changes: 1 addition & 1 deletion packages/qgrid-core/src/column/column.service.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ export declare function lineView(columnRows: ColumnView[]): string;
export declare function widthFactory(table: Table, form: Map<string, any>): number;

export declare function flattenColumns(columns: ColumnModel[]): ColumnModel[];
export declare function findLine(columns: ColumnModel[], key: string): { columns: ColumnModel[]; index: number } | null;
export declare function findLine(columns: ColumnModel[], key: string): any;
Copy link
Collaborator

@klumba12 klumba12 May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it was removed?

2 changes: 1 addition & 1 deletion packages/qgrid-core/src/focus/focus.service.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { GridPlugin } from '../plugin/grid.plugin';
export declare class FocusService {
constructor(model: Model);

activate(rowIndex?: number, columnIndex?: number);
activate(rowIndex?: number, columnIndex?: number): void;
}

export declare class FocusAfterRenderService {
Expand Down
4 changes: 2 additions & 2 deletions packages/qgrid-core/src/head/head.host.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import { GridPlugin } from '../plugin/grid.plugin';
export declare class HeadHost {
constructor(plugin: GridPlugin);

mouseMove(e: MouseEvent);
mouseLeave(e: MouseEvent);
mouseMove(e: MouseEvent): void;
mouseLeave(e: MouseEvent): void;
}
4 changes: 2 additions & 2 deletions packages/qgrid-core/src/infrastructure/cache.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
export declare class Cache <K, V> {
constructor();

set(key: K, value: V);
get(key: K): V ;
set(key: K, value: V): void;
get(key: K): V;
has(key: K): boolean;
find(key: K): V;
remove(key: K): void;
Expand Down
2 changes: 1 addition & 1 deletion packages/qgrid-core/src/infrastructure/composite.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Command } from '../command/command';

export declare class Composite {
static func<T, A>(list: ((...args) => T)[], reducer?: (A, T) => A, memo?: A): (...args) => A;
static func<T, A>(list: ((...args: any) => T)[], reducer?: (A: any, T: any) => A, memo?: A): (...args: any) => A;
Copy link
Collaborator

@klumba12 klumba12 May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange

static command(list: Command[]): Command;
static list(list: any[]): any[];
static object(list: any[], memo: any): any;
Expand Down
278 changes: 141 additions & 137 deletions packages/qgrid-core/src/rx/rx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,108 +2,112 @@ import { Event } from '../event/event';
import { Disposable } from '../infrastructure/disposable';

export declare interface ObserverLike<T> {
next(value?: T): void;
error(ex: Error): void;
complete(): void;
next(value?: T): void;
error(ex: Error): void;
complete(): void;
}

export declare interface UnsubscribableLike {
readonly closed: boolean;
unsubscribe(): void;
readonly closed: boolean;
unsubscribe(): void;
}

export declare interface SubscribableLike<T> {
subscribe(observer?: Partial<ObserverLike<T>>): UnsubscribableLike;
/** @deprecated Use an observer instead of an error callback */
subscribe(next: null | undefined, error: (error: any) => void, complete?: () => void): UnsubscribableLike;
/** @deprecated Use an observer instead of a complete callback */
subscribe(next: null | undefined | ((value: T) => void), error: null | undefined, complete: () => void): UnsubscribableLike;
subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): UnsubscribableLike;
subscribe(observer?: Partial<ObserverLike<T>>): UnsubscribableLike;
/** @deprecated Use an observer instead of an error callback */
subscribe(next: null | undefined, error: (error: any) => void, complete?: () => void): UnsubscribableLike;
/** @deprecated Use an observer instead of a complete callback */
subscribe(next: null | undefined | ((value: T) => void), error: null | undefined, complete: () => void): UnsubscribableLike;
subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): UnsubscribableLike;
}

export type UnaryFunctionLike<T, R> = (source: T) => R;

// eslint-disable-next-line no-use-before-define
export declare interface OperatorFunctionLike<T, R> extends UnaryFunctionLike<ObservableLike<T>, ObservableLike<R>> {
type?: T;
type?: T;
}
export declare interface ObservableLike<T> extends SubscribableLike<T> {
toPromise(): Promise<T>;
toPromise(): Promise<T>;

pipe(): ObservableLike<T>;
pipe<A>(op1: OperatorFunctionLike<T, A>): ObservableLike<A>;
pipe<A, B>(op1: OperatorFunctionLike<T, A>, op2: OperatorFunctionLike<A, B>): ObservableLike<B>;
pipe<A, B, C>(op1: OperatorFunctionLike<T, A>, op2: OperatorFunctionLike<A, B>, op3: OperatorFunctionLike<B, C>): ObservableLike<C>;
pipe<A, B, C, D>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>
): ObservableLike<D>;
pipe<A, B, C, D, E>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>
): ObservableLike<E>;
pipe<A, B, C, D, E, F>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>
): ObservableLike<F>;
pipe<A, B, C, D, E, F, G>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>
): ObservableLike<G>;
pipe<A, B, C, D, E, F, G, H>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>
): ObservableLike<H>;
pipe<A, B, C, D, E, F, G, H, I>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>
): ObservableLike<I>;
pipe<A, B, C, D, E, F, G, H, I>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>,
...operations: OperatorFunctionLike<any, any>[]
): ObservableLike<any>;
pipe(): ObservableLike<T>;
pipe<A>(op1: OperatorFunctionLike<T, A>): ObservableLike<A>;
pipe<A, B>(op1: OperatorFunctionLike<T, A>, op2: OperatorFunctionLike<A, B>): ObservableLike<B>;
pipe<A, B, C>(op1: OperatorFunctionLike<T, A>, op2: OperatorFunctionLike<A, B>, op3: OperatorFunctionLike<B, C>): ObservableLike<C>;
pipe<A, B, C, D>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>
): ObservableLike<D>;
pipe<A, B, C, D, E>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>
): ObservableLike<E>;
pipe<A, B, C, D, E, F>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>
): ObservableLike<F>;
pipe<A, B, C, D, E, F, G>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>
): ObservableLike<G>;
pipe<A, B, C, D, E, F, G, H>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>
): ObservableLike<H>;
pipe<A, B, C, D, E, F, G, H, I>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>
): ObservableLike<I>;
pipe<A, B, C, D, E, F, G, H, I>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>,
...operations: OperatorFunctionLike<any, any>[]
): ObservableLike<any>;
}

export declare class ObservableEvent<T> implements ObservableLike<T> {
constructor(event: Event<T>, disposable: Disposable);

subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): UnsubscribableLike;
subscribe(observer: Partial<ObserverLike<T>>): UnsubscribableLike;
subscribe(observer?: Partial<ObserverLike<T>>): UnsubscribableLike;
/** @deprecated Use an observer instead of an error callback */
subscribe(next: null | undefined, error: (error: any) => void, complete?: () => void): UnsubscribableLike;
/** @deprecated Use an observer instead of a complete callback */
subscribe(next: null | undefined | ((value: T) => void), error: null | undefined, complete: () => void): UnsubscribableLike;

toPromise(): Promise<T>;

Expand All @@ -112,68 +116,68 @@ export declare class ObservableEvent<T> implements ObservableLike<T> {
pipe<A, B>(op1: OperatorFunctionLike<T, A>, op2: OperatorFunctionLike<A, B>): ObservableLike<B>;
pipe<A, B, C>(op1: OperatorFunctionLike<T, A>, op2: OperatorFunctionLike<A, B>, op3: OperatorFunctionLike<B, C>): ObservableLike<C>;
pipe<A, B, C, D>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>
): ObservableLike<D>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>
): ObservableLike<D>;
pipe<A, B, C, D, E>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>
): ObservableLike<E>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>
): ObservableLike<E>;
pipe<A, B, C, D, E, F>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>
): ObservableLike<F>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>
): ObservableLike<F>;
pipe<A, B, C, D, E, F, G>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>
): ObservableLike<G>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>
): ObservableLike<G>;
pipe<A, B, C, D, E, F, G, H>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>
): ObservableLike<H>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>
): ObservableLike<H>;
pipe<A, B, C, D, E, F, G, H, I>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>
): ObservableLike<I>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>
): ObservableLike<I>;
pipe<A, B, C, D, E, F, G, H, I>(
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>,
...operations: OperatorFunctionLike<any, any>[]
): ObservableLike<any>;
op1: OperatorFunctionLike<T, A>,
op2: OperatorFunctionLike<A, B>,
op3: OperatorFunctionLike<B, C>,
op4: OperatorFunctionLike<C, D>,
op5: OperatorFunctionLike<D, E>,
op6: OperatorFunctionLike<E, F>,
op7: OperatorFunctionLike<F, G>,
op8: OperatorFunctionLike<G, H>,
op9: OperatorFunctionLike<H, I>,
...operations: OperatorFunctionLike<any, any>[]
): ObservableLike<any>;
}

export declare class ObservableReplyEvent<T> extends ObservableEvent<T> {
Expand Down
2 changes: 1 addition & 1 deletion packages/qgrid-core/src/selection/selection.service.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ export declare class SelectionService {

lookup(items: any[], unit?: string): any[];
map(entries: any[]): any[];
keyFactory<K>(unit: string): (any) => K;
keyFactory<K>(unit: string): (any: any) => K;
Copy link
Collaborator

@klumba12 klumba12 May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange

hashFactory(): (key: string) => any;
}
2 changes: 1 addition & 1 deletion packages/qgrid-core/src/services/fastdom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export declare class Fastdom {
static mutate: (task: () => void) => any;
static measure: (task: () => void) => any;
static clear(token: any);
static clear(token: any): (task: () => void) => any;
Copy link
Collaborator

@klumba12 klumba12 May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are u sure?

static invoke: (task: () => void) => any;
}
Loading