Skip to content

Fixed router not returning headers #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kostrahb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed router not returning headers #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ type Context struct {
handlers []Handler // the handlers associated with the current route
}

var defaultContentType = []byte("text/plain; charset=utf-8")
// Error sets response status code to the given value and sets response body
// to the given message.
func (c *Context) ErrorWithHeaders(msg string, statusCode int) {
c.SetStatusCode(statusCode)
c.SetContentTypeBytes(defaultContentType)
c.SetBodyString(msg)
}

// Router returns the Router that is handling the incoming HTTP request.
func (c *Context) Router() *Router {
return c.router
Expand Down
4 changes: 2 additions & 2 deletions router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ func (r *Router) NotFound(handlers ...Handler) {
// handleError is the error handler for handling any unhandled errors.
func (r *Router) handleError(c *Context, err error) {
if httpError, ok := err.(HTTPError); ok {
c.Error(httpError.Error(), httpError.StatusCode())
c.ErrorWithHeaders(httpError.Error(), httpError.StatusCode())
} else {
c.Error(err.Error(), http.StatusInternalServerError)
c.ErrorWithHeaders(err.Error(), http.StatusInternalServerError)
}
}

Expand Down