Merge remote-tracking branch 'upstream/master' #9
Annotations
54 warnings
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
doc list item missing indentation:
src/serde/de/indexed.rs#L41
warning: doc list item missing indentation
--> src/serde/de/indexed.rs:41:5
|
41 | /// generates artificial indices (which just count up by 1 for each field) for error messages.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
41 | /// generates artificial indices (which just count up by 1 for each field) for error messages.
| ++
|
doc list item missing indentation:
src/serde/de/indexed.rs#L40
warning: doc list item missing indentation
--> src/serde/de/indexed.rs:40:5
|
40 | /// fields has to occur based on the how many-th field they are. In this case the deserializer
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
40 | /// fields has to occur based on the how many-th field they are. In this case the deserializer
| ++
|
doc list item missing indentation:
src/serde/de/indexed.rs#L38
warning: doc list item missing indentation
--> src/serde/de/indexed.rs:38:5
|
38 | /// unique and tells us which field follows.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
38 | /// unique and tells us which field follows.
| ++
|
you are explicitly cloning with `.map()`:
src/response.rs#L80
warning: you are explicitly cloning with `.map()`
--> src/response.rs:80:24
|
80 | let song = level
| ________________________^
81 | | .custom_song
82 | | .and_then(|song_id| songs.iter().find(|song| song.song_id == song_id))
83 | | .map(Clone::clone);
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
help: consider calling the dedicated `cloned` method
|
80 ~ let song = level
81 + .custom_song
82 ~ .and_then(|song_id| songs.iter().find(|song| song.song_id == song_id)).cloned();
|
|
you are explicitly cloning with `.map()`:
src/response.rs#L79
warning: you are explicitly cloning with `.map()`
--> src/response.rs:79:27
|
79 | let creator = creators.iter().find(|creator| creator.user_id == level.creator).map(Clone::clone);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `creators.iter().find(|creator| creator.user_id == level.creator).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
|
direct implementation of `ToString`:
src/request/user.rs#L117
warning: direct implementation of `ToString`
--> src/request/user.rs:117:1
|
117 | / impl ToString for UserSearchRequest<'_> {
118 | | fn to_string(&self) -> String {
119 | | super::to_string(self)
120 | | }
121 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
direct implementation of `ToString`:
src/request/user.rs#L54
warning: direct implementation of `ToString`
--> src/request/user.rs:54:1
|
54 | / impl ToString for UserRequest<'_> {
55 | | fn to_string(&self) -> String {
56 | | super::to_string(self)
57 | | }
58 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
direct implementation of `ToString`:
src/request/level.rs#L591
warning: direct implementation of `ToString`
--> src/request/level.rs:591:1
|
591 | / impl ToString for LevelsRequest<'_> {
592 | | fn to_string(&self) -> String {
593 | | super::to_string(self)
594 | | }
595 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
doc list item missing indentation:
src/request/level.rs#L291
warning: doc list item missing indentation
--> src/request/level.rs:291:5
|
291 | /// same as `0` ([`LevelRequestType::Search`]) and `6` ([`LevelRequestType::Featured`]) respectively
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
291 | /// same as `0` ([`LevelRequestType::Search`]) and `6` ([`LevelRequestType::Featured`]) respectively
| ++
|
doc list item missing indentation:
src/request/level.rs#L223
warning: doc list item missing indentation
--> src/request/level.rs:223:9
|
223 | /// `completedLevels` is omitted.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
223 | /// `completedLevels` is omitted.
| ++
|
doc list item missing indentation:
src/request/level.rs#L222
warning: doc list item missing indentation
--> src/request/level.rs:222:9
|
222 | /// If no completion filtering is desired, both boolean fields are set to `0` and
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
222 | /// If no completion filtering is desired, both boolean fields are set to `0` and
| ++
|
direct implementation of `ToString`:
src/request/level.rs#L92
warning: direct implementation of `ToString`
--> src/request/level.rs:92:1
|
92 | / impl ToString for LevelRequest<'_> {
93 | | fn to_string(&self) -> String {
94 | | super::to_string(self)
95 | | }
96 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
direct implementation of `ToString`:
src/request/comment.rs#L184
warning: direct implementation of `ToString`
--> src/request/comment.rs:184:1
|
184 | / impl ToString for ProfileCommentsRequest<'_> {
185 | | fn to_string(&self) -> String {
186 | | super::to_string(self)
187 | | }
188 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
direct implementation of `ToString`:
src/request/comment.rs#L116
warning: direct implementation of `ToString`
--> src/request/comment.rs:116:1
|
116 | / impl ToString for LevelCommentsRequest<'_> {
117 | | fn to_string(&self) -> String {
118 | | super::to_string(self)
119 | | }
120 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
doc list item missing indentation:
src/model/level/mod.rs#L446
warning: doc list item missing indentation
--> src/model/level/mod.rs:446:5
|
446 | /// index 9, dash-rs ignores this value.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
446 | /// index 9, dash-rs ignores this value.
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L445
warning: doc list item missing indentation
--> src/model/level/mod.rs:445:5
|
445 | /// In other cases it's hard demon (thanks Ryder!). However, since we extract this information from
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
445 | /// In other cases it's hard demon (thanks Ryder!). However, since we extract this information from
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L444
warning: doc list item missing indentation
--> src/model/level/mod.rs:444:5
|
444 | /// 6 = extreme demon.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
444 | /// 6 = extreme demon.
| +
|
doc list item missing indentation:
src/model/level/mod.rs#L443
warning: doc list item missing indentation
--> src/model/level/mod.rs:443:5
|
443 | /// 5 = insane demon,
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
443 | /// 5 = insane demon,
| +
|
doc list item missing indentation:
src/model/level/mod.rs#L442
warning: doc list item missing indentation
--> src/model/level/mod.rs:442:5
|
442 | /// 4 = medium demon,
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
442 | /// 4 = medium demon,
| +
|
doc list item missing indentation:
src/model/level/mod.rs#L441
warning: doc list item missing indentation
--> src/model/level/mod.rs:441:5
|
441 | /// 3 = easy demon,
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
441 | /// 3 = easy demon,
| +
|
doc list item missing indentation:
src/model/level/mod.rs#L439
warning: doc list item missing indentation
--> src/model/level/mod.rs:439:5
|
439 | /// [`LevelRating::Auto`]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
439 | /// [`LevelRating::Auto`]
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L438
warning: doc list item missing indentation
--> src/model/level/mod.rs:438:5
|
438 | /// [`Level::difficulty`] is equal to
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
438 | /// [`Level::difficulty`] is equal to
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L437
warning: doc list item missing indentation
--> src/model/level/mod.rs:437:5
|
437 | /// whether the level is an auto level. This is equivalent to checking if
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
437 | /// whether the level is an auto level. This is equivalent to checking if
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L435
warning: doc list item missing indentation
--> src/model/level/mod.rs:435:5
|
435 | /// [`Level::difficulty`] is the [`LevelRating::Demon`] variant.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
435 | /// [`Level::difficulty`] is the [`LevelRating::Demon`] variant.
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L434
warning: doc list item missing indentation
--> src/model/level/mod.rs:434:5
|
434 | /// the level is a demon level. This is equivalent to checking if
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
434 | /// the level is a demon level. This is equivalent to checking if
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L432
warning: doc list item missing indentation
--> src/model/level/mod.rs:432:5
|
432 | /// [`LevelRating::NotAvailable`]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
432 | /// [`LevelRating::NotAvailable`]
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L431
warning: doc list item missing indentation
--> src/model/level/mod.rs:431:5
|
431 | /// [`Level::difficulty`] is unequal to
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
431 | /// [`Level::difficulty`] is unequal to
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L430
warning: doc list item missing indentation
--> src/model/level/mod.rs:430:5
|
430 | /// difficulty rating that isn't N/A. This is equivalent to checking if
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
430 | /// difficulty rating that isn't N/A. This is equivalent to checking if
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L353
warning: doc list item missing indentation
--> src/model/level/mod.rs:353:9
|
353 | /// encoding described in [`Password`]'s documentation
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
353 | /// encoding described in [`Password`]'s documentation
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L289
warning: doc list item missing indentation
--> src/model/level/mod.rs:289:9
|
289 | /// that changed at some point after 1.7
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
289 | /// that changed at some point after 1.7
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L288
warning: doc list item missing indentation
--> src/model/level/mod.rs:288:9
|
288 | /// for the game to be able to correctly process passwords, and merely an implementation detail
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
288 | /// for the game to be able to correctly process passwords, and merely an implementation detail
| ++
|
doc list item missing indentation:
src/model/level/mod.rs#L287
warning: doc list item missing indentation
--> src/model/level/mod.rs:287:9
|
287 | /// In-Game, passwords are sometimes left-padded with zeros. However, this is not a requirement
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
287 | /// In-Game, passwords are sometimes left-padded with zeros. However, this is not a requirement
| ++
|
bound is defined in more than one place:
src/serde/ser/request.rs#L426
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:426:26
|
426 | fn serialize_element<T: ?Sized>(&mut self, value: &T) -> Result<(), Self::Error>
| ^
427 | where
428 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L408
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:408:20
|
408 | fn collect_str<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
409 | where
410 | T: Display,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L341
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:341:34
|
341 | fn serialize_newtype_variant<T: ?Sized>(
| ^
...
345 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L334
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:334:33
|
334 | fn serialize_newtype_struct<T: ?Sized>(self, _name: &'static str, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
335 | where
336 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L315
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:315:23
|
315 | fn serialize_some<T: ?Sized>(self, value: &T) -> Result<Self::Ok, Self::Error>
| ^
316 | where
317 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L160
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:160:24
|
160 | fn serialize_field<T: ?Sized>(&mut self, key: &'static str, value: &T) -> Result<(), Self::Error>
| ^
161 | where
162 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L148
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:148:20
|
148 | fn collect_str<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
149 | where
150 | T: Display,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L107
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:107:34
|
107 | fn serialize_newtype_variant<T: ?Sized>(
| ^
...
111 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L100
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:100:33
|
100 | fn serialize_newtype_struct<T: ?Sized>(self, _name: &'static str, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
101 | where
102 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/request.rs#L81
warning: bound is defined in more than one place
--> src/serde/ser/request.rs:81:23
|
81 | fn serialize_some<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
82 | where
83 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/indexed.rs#L237
warning: bound is defined in more than one place
--> src/serde/ser/indexed.rs:237:24
|
237 | fn serialize_field<T: ?Sized>(&mut self, key: &'static str, value: &T) -> Result<(), Self::Error>
| ^
238 | where
239 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/indexed.rs#L225
warning: bound is defined in more than one place
--> src/serde/ser/indexed.rs:225:20
|
225 | fn collect_str<T: ?Sized>(self, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
226 | where
227 | T: Display,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/indexed.rs#L183
warning: bound is defined in more than one place
--> src/serde/ser/indexed.rs:183:34
|
183 | fn serialize_newtype_variant<T: ?Sized>(
| ^
...
187 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/indexed.rs#L176
warning: bound is defined in more than one place
--> src/serde/ser/indexed.rs:176:33
|
176 | fn serialize_newtype_struct<T: ?Sized>(self, _name: &'static str, _value: &T) -> Result<Self::Ok, Self::Error>
| ^
177 | where
178 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
bound is defined in more than one place:
src/serde/ser/indexed.rs#L157
warning: bound is defined in more than one place
--> src/serde/ser/indexed.rs:157:23
|
157 | fn serialize_some<T: ?Sized>(self, value: &T) -> Result<Self::Ok, Self::Error>
| ^
158 | where
159 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
you are explicitly cloning with `.map()`:
dash-rs-derive/src/utils.rs#L8
warning: you are explicitly cloning with `.map()`
--> dash-rs-derive/src/utils.rs:8:26
|
8 | let first_lifetime = lifetime_iter.next().map(Clone::clone);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `lifetime_iter.next().cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
|