CR Hamiltonian tomo with group fit #718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add new feature - CurveAnalysis.curve_fit: this is class method, user can directly call fit function - CompositeFitFunction: a function-like object for fitting In addition unittest of curve analysis and class documentation are overhauled. Following is deprecated - CurveAnalysis.options.curve_fitter: This object is not serializable
…ade/curve_analysis_with_group_fit
The composite_func is no longer class attribute. It is converted into protected member and replaced with property method. This property method returns a copy of function to avoid conflict in the multithread execution. The parameter ordering is also fixed to match with original fit function signature.
nkanazawa1989
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
CrossResonanceHamiltonianAnalysisto perform fitting for curves with different control state separately. It has been a single multi-objective optimization though fit initial guesses for different control states are provided independently. This means we needed to test all O(N^2) init guesses (currently 225 loops) to find the best solution.Now it uses
groupfeature introduced in #715. With this update the number of loops is reduced from 225 to 2x15 which is much faster.TODO: write reno
Details and comments
This is dependent on #715 thus should be merged after