Skip to content

Conversation

@q-inho
Copy link

@q-inho q-inho commented Nov 23, 2023

What are the issues this pull addresses (issue numbers / links)?

The issues occur due to AttributeError: module numpy has no attribute float.
np.float was a deprecated alias for the builtin float.

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

Details and comments

This error happens due the pyepr-quantum package when running run_epr()
Thanks to this PR this problem is solved since pyepr-quantum==0.9.0

@zlatko-minev
Copy link
Collaborator

Did you test to see that you can install and use without issues after the upgrade here?

@q-inho
Copy link
Author

q-inho commented Nov 26, 2023

Yes. I tested installing of pyEPR-quantum version of 0.9.0 with this change and AtrributeError is solved through this upgrade.

@zlatko-minev
Copy link
Collaborator

Thank you

@PositroniumJS
Copy link
Contributor

PositroniumJS commented Jan 4, 2025

@zlatko-minev I humbly suggest that it would be good to merge this PR before the 0.5.0 update

Fix #988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants