Skip to content

Set black line length to 100 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Set black line length to 100 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
776fc38
Set black line length to 100
garrison Apr 4, 2022
941a5f4
Actually run black with the new line length
garrison Apr 4, 2022
515d55c
Revert "Update CONTRIBUTING with default black line length (#45)"
garrison Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Users are encouraged to use GitHub Discussions for engaging with researchers, de

### Project Code Style

Code in this repository should conform to PEP8 standards. Style/lint checks are run to validate this. Line length must be limited to no more than 88 characters.
Code in this repository should conform to PEP8 standards. Style/lint checks are run to validate this. Line length must be limited to no more than 100 characters.

### Pull Request Checklist

Expand Down
4 changes: 1 addition & 3 deletions prototype_template/template_module/template_class.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ class TemplateClass:

def __init__(
self,
some_parameter: Union[
int, float, str, bool, List[Union[int, float, str, bool]]
],
some_parameter: Union[int, float, str, bool, List[Union[int, float, str, bool]]],
optional_parameter: Optional[
Union[int, float, str, bool, List[Union[int, float, str, bool]]]
] = None,
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[tool.black]
line-length = 100
target-version = ['py37', 'py38', 'py39', 'py310']
3 changes: 2 additions & 1 deletion tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Environments for this repository are configured in [`tox.ini`] as described belo

The `lint` environment ensures that the code meets basic coding standards, including

- [_Black_] formatting style
- [_Black_] formatting style, as configured by [`pyproject.toml`]
- [mypy] type annotation checker, as configured by [`mypy.ini`]
- [pylint], as configured by [`.pylintrc`]

Expand Down Expand Up @@ -63,6 +63,7 @@ $ tox -ecoverage
[`mypy.ini`]: /mypy.ini
[treon]: https://github.com/ReviewNB/treon
[_Black_]: https://github.com/psf/black
[`pyproject.toml`]: /pyproject.toml
[pylint]: https://github.com/PyCQA/pylint
[`.pylintrc`]: /.pylintrc
[nbqa]: https://github.com/nbQA-dev/nbQA
Expand Down