feat: support measuring text with font weight #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanho
requested review from
johanlahti,
Caele,
T-Wizard,
veinfors and
PurwaShrivastava
johanlahti
approved these changes
Nov 14, 2024
cbt1
reviewed
Nov 14, 2024
cbt1
reviewed
Nov 14, 2024
cbt1
reviewed
Nov 14, 2024
quanho
changed the title
T-Wizard
approved these changes
Nov 14, 2024
cbt1
reviewed
Nov 14, 2024
| } else { | ||
| g.font = `${t['font-size']} ${t['font-family']}`; | ||
| } | ||
| g.font = [t['font-style'], t['font-weight'], t['font-size'], t['font-family']].filter((v) => !!v).join(' '); |
There was a problem hiding this comment.
Nitpicking here but it does not seem optional from a performance perspective to
- Create an array
filterto create another arrayjoinarray
...everytime we render a text.
I would think string concat is a faster and provides a somewhat clean syntax. Some simpified tested in the browser console at least gave to a 50% performance increase compered to current method.
Example:
g.font = (t["font-style"] ?? "").concat(t['font-weight'] ?? ", t['font-size'] ?? "", t['font-family'] ?? "")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to support measure text with styling e.g bold and/or italic
Checklist