fix: allow padding functions 2 #886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added radial axis * feat: added radial axis * feat: added center offset for label positioning * feat: updating arc tick color * fix: fixed a bug with labelplacement * refactor: changed name of radius property in arc-axis * fix: added default value to radius property * fix: arc axis ticklength * refactor: removed unnecessary props in arc-node * fix: fixed out of bounds bug in axis-arc-label * fix: removed tickColor, updated axis-default-settings and added arc-padding * refactor: removed unecessary use of radius * docs: doc for radial axis * feat: added unit tests * feat: unit test for rendering radial axis * fix: removed logs * fix: removed chai import in unit test * feat: added radialboundschecking and corrected unit tests * fix: removed unnecessary collider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR is a continuation from my last PR #880
It handles the cases where paddings can be functions. This comes in handy when there is a need for flexible placement of labels that are dependent on some bars.