fix: allow padding function 2 #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veinfors
reviewed
Dec 3, 2024
| @@ -209,6 +209,10 @@ export function findBestPlacement( | |||
|
|
|||
| function approxTextBounds(label, textMetrics, rotated, rect, padding = {}) { | |||
| const { top = PADDING, bottom = PADDING, left = PADDING, right = PADDING } = padding; | |||
| const leftPadding = typeof left === 'function' ? left(textMetrics) : left; | |||
There was a problem hiding this comment.
This is the same padding properties as you added and documented in your previous PR, right? So there is no need for adding anything new in the api specs if I understand correct.
Could you adjust the testcase you added in. the last pr to also validate these bounds gets calculated using the functions?
quanho
approved these changes
Feb 10, 2025
…w-padding-functions-4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR is a continuation from my last PR #880
It handles the cases where paddings can be functions. This comes in handy when there is a need for flexible placement of labels that are dependent on some bars.