Skip redundant init queries by reading the config blob#22
Open
arakashic wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configwithmanufacturer,keyboard_name,usb,dynamic_keymap,features(parsed from the QMK config blob the app already fetches).QmkBoardIdentifiers,QmkBoardManufacturer,QmkProductName,KeymapGetLayerCount,RemappingGetLayerCount— same values come from the blob.LightingCapabilitiesquery whenfeatures.{backlight,rgblight,rgb_matrix,led_matrix}are all false (observed: some boards advertise the Lighting subsystem bit while the build has no lighting features).features.encoder_map(the dynamic-remap framework) instead of just encoder hardware presence.Dependencies
Depends on #21 (Encoder Map), which depends on #19 (Keycode pipeline). Merge order: #19 → #21 → this.
The PR diff will shrink to its 5 own commits once both bases land.
Test plan
cargo build/cargo test/yarn ts-checkcleanENCODER_MAP_ENABLE=yes: Encoder tab showsencoder_mapfeature: Encoder tab hiddenLightingCapabilitiesquery in logs