-
Notifications
You must be signed in to change notification settings - Fork 0
[3006][ADD] purchase_report_qweb_decimal_place #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AungKoKoLin1997 Can we put this module in https://github.com/OCA/purchase-reporting?
| @@ -0,0 +1 @@ | |||
| This module provides the price unit format of purchase report depends on the choice of price_decimal_places in currency. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This module provides the price unit format of purchase report depends on the choice of price_decimal_places in currency. | |
| This module provides the option to adjust the price unit format (number of decimal places to apply) | |
| of purchase report according to the configuration of price_decimal_places in currency. | |
| This module depends on report_qweb_decimal_place module in OCA/reporting-engine. |
| <xpath expr="//tbody//tr//td[5]" position="replace"> | ||
| <td class="text-end"> | ||
| <t t-set="currency" t-value="o.currency_id" /> | ||
| <t t-set="price_unit" t-value="line.price_unit" /> | ||
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | ||
| </td> | ||
| </xpath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <xpath expr="//tbody//tr//td[5]" position="replace"> | |
| <td class="text-end"> | |
| <t t-set="currency" t-value="o.currency_id" /> | |
| <t t-set="price_unit" t-value="line.price_unit" /> | |
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | |
| </td> | |
| </xpath> | |
| <xpath expr="//span[@t-field='line.price_unit']" position="replace"> | |
| <t t-set="currency" t-value="o.currency_id" /> | |
| <t t-set="price_unit" t-value="line.price_unit" /> | |
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | |
| </xpath> |
To make the intention clearer and the design less breakable.
| <xpath expr="//span[@t-field='line.price_unit']" position="replace"> | ||
| <t t-set="currency" t-value="o.currency_id" /> | ||
| <t t-set="price_unit" t-value="line.price_unit" /> | ||
| <t t-call="report_qweb_decimal_place.price_unit_value_format" /> | ||
| </xpath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on this discussion: #6 (review)
| @@ -0,0 +1,4 @@ | |||
| his module provides the option to adjust the price unit format (number of decimal places to apply) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| his module provides the option to adjust the price unit format (number of decimal places to apply) | |
| This module provides the option to adjust the price unit format (number of decimal places to apply) |
1730284 to
7ab3078
Compare
|
Same issue as #6 (comment). Ran pre-commit locally to confirm there is not issue. |
3006