Skip to content

Conversation

@AungKoKoLin1997
Copy link
Contributor

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1 @@
This module provides the price unit format of purchase report depends on the choice of price_decimal_places in currency.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module provides the price unit format of purchase report depends on the choice of price_decimal_places in currency.
This module provides the option to adjust the price unit format (number of decimal places to apply)
of purchase report according to the configuration of price_decimal_places in currency.
This module depends on report_qweb_decimal_place module in OCA/reporting-engine.

Comment on lines 8 to 16
<xpath expr="//tbody//tr//td[5]" position="replace">
<td class="text-end">
<t t-set="currency" t-value="o.currency_id" />
<t t-set="price_unit" t-value="line.price_unit" />
<t t-call="report_qweb_decimal_place.price_unit_value_format" />
</td>
</xpath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xpath expr="//tbody//tr//td[5]" position="replace">
<td class="text-end">
<t t-set="currency" t-value="o.currency_id" />
<t t-set="price_unit" t-value="line.price_unit" />
<t t-call="report_qweb_decimal_place.price_unit_value_format" />
</td>
</xpath>
<xpath expr="//span[@t-field='line.price_unit']" position="replace">
<t t-set="currency" t-value="o.currency_id" />
<t t-set="price_unit" t-value="line.price_unit" />
<t t-call="report_qweb_decimal_place.price_unit_value_format" />
</xpath>

To make the intention clearer and the design less breakable.

Comment on lines 8 to 16
<xpath expr="//span[@t-field='line.price_unit']" position="replace">
<t t-set="currency" t-value="o.currency_id" />
<t t-set="price_unit" t-value="line.price_unit" />
<t t-call="report_qweb_decimal_place.price_unit_value_format" />
</xpath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on this discussion: #6 (review)

@@ -0,0 +1,4 @@
his module provides the option to adjust the price unit format (number of decimal places to apply)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
his module provides the option to adjust the price unit format (number of decimal places to apply)
This module provides the option to adjust the price unit format (number of decimal places to apply)

@yostashiro yostashiro force-pushed the 16.0-add-purchase_report_qweb_decimal_place branch from 1730284 to 7ab3078 Compare January 28, 2023 15:42
@yostashiro
Copy link
Member

Same issue as #6 (comment). Ran pre-commit locally to confirm there is not issue.

@yostashiro yostashiro merged commit de007af into 16.0 Jan 28, 2023
@AungKoKoLin1997 AungKoKoLin1997 deleted the 16.0-add-purchase_report_qweb_decimal_place branch March 13, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants