-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5148][ADD] account_move_delivery_invoice #2
base: 16.0
Are you sure you want to change the base?
Conversation
e924b33
to
f94f9cd
Compare
Should we propose this module to OCA? |
f94f9cd
to
89d5c5c
Compare
@kanda999 Please review my latest code. I was not on the right track and was stuck for a few hours. |
@AungKoKoLin1997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about account_move_delivery_invoice
for the module name?
There are two approaches for the report template:
Option 1. Inherit account.report_invoice_document
and add necessary adjustments (the current approach)
Option 2. Copy account.report_invoice_document
to define a new template, and add necessary adjustments
While Option 1 is reasonable when adjustments are limited and we can accept all changes in the upstream, the template may get cluttered and become hard to comprehend without looking closely at the origin template.
I'm inclined to think that Option 2 is better for this module.
@kanda999 What do you think?
I thought Option 2 would be better too. @AungKoKoLin1997 |
@kanda999 Done! |
I reviewed your code and removed the sections that were not necessary for the delivery slip. @AungKoKoLin1997 |
5148