Add CPDB support to Qt Print Dialog (GSoC 2022 integration) #122
+2,653
−887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Common Print Dialog Backends (CPDB) concept has GUI-toolkit-independent backends for each print technology (CUPS, Print to File, cloud printing services, ...) and each print dialog (GTK, Qt, Chromium, Firefox, ...) is supposed to use this backend, so that changes in print technologies can be centrally and quickly covered by changing the backends and everything new gets available in all print dialogs. This commit provides Qt print dialog implementation which adds support for the CPDB concept. It communincates with all the installed CPDB backends and so gives support for all these print technologies to the Qt print dialog. To make use of CPDB, Qt should be configured with cpdb and cpdbjobwidget enabled and other print technologies (eg. cups and cupsjobwidget) disabled to prevent printer duplication. Change-Id: Ic97c41979040adb6e9ffab540c09edadb6b5de3e
Scraped out CUPS & CPDB specific code from print dialog frontend, and put it in their respective print plugin directories. This allows the print dialog to be able to dynamically select print backends at runtime instead of having to choose one at build time. Change-Id: I8ae53d19d91aa9689ec327fd8077558744e4768b
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates Gaurav's CPDB (Common Print Dialog Backends) support from GSoC 2022.
Key changes:
Testing completed: