fix(init): write project mempalace.json in interactive mode#8
Merged
Conversation
The interactive (non --yes) branch of `mpr init <dir>` told the user their next step was `mpr mine <dir>`, but never produced the `mempalace.json` project config that `mpr mine` needs. Mining then failed with "No mempalace config found in <dir>". The --yes path already detects rooms from the folder structure and calls save_project_config; mirror that behaviour after run_onboarding so both paths leave the project ready to mine. Added a regression test that drives cmd_init with yes=false and MEMPALACE_NONINTERACTIVE=1 and asserts mempalace.json is written and load_config can read it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interactive (non --yes) branch of
".mpr init <dir>told the user their next step wasmpr mine <dir>, but never produced themempalace.jsonproject config thatmpr mineneeds. Mining then failed with "No mempalace config found inThe --yes path already detects rooms from the folder structure and calls save_project_config; mirror that behaviour after run_onboarding so both paths leave the project ready to mine.
Added a regression test that drives cmd_init with yes=false and MEMPALACE_NONINTERACTIVE=1 and asserts mempalace.json is written and load_config can read it back.