fix(serve): honor --palace; fix MCP unknown-tool message; document sweep#9
Merged
quangdang46 merged 1 commit intoMay 17, 2026
Conversation
Three release-blocker findings from end-to-end testing: 1. mpr --palace <dir> serve silently ignored --palace and always used the global ~/.config/mempalace/config.json. Thread palace_arg through run_server and let it override config.palace_path so users connecting their AI client to a project palace can do so without re-init'ing the global config. ~/ expansion mirrors resolve_palace_path. 2. tools/call for an unknown tool name returned JSON-RPC -32601 with message='tools/call' (echoing the method name, not the bad tool). Switch to -32602 (invalid_params, which is what a bad 'name' param actually is) and surface 'Unknown tool: <name>' so MCP clients get an actionable error. 3. mpr sweep had no description in --help. Add a clap doc comment so it stops looking like an undocumented hidden command. Adds 4 regression tests: - test_unknown_tool_returns_invalid_params_with_tool_name - test_resolve_palace_override_expands_tilde_home - test_resolve_palace_override_absolute_path_passthrough - test_resolve_palace_override_relative_path_passthrough cargo fmt clean, clippy -D warnings 0, 424 tests pass.
quangdang46
deleted the
devin/1779022609-fix-serve-palace-and-mcp-error-msg
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three release-blocker findings from end-to-end testing:
mpr --palace
serve silently ignored --palace and always used the global ~/.config/mempalace/config.json. Thread palace_arg through run_server and let it override config.palace_path so users connecting their AI client to a project palace can do so without re-init'ing the global config. ~/ expansion mirrors resolve_palace_path.tools/call for an unknown tool name returned JSON-RPC -32601 with message='tools/call' (echoing the method name, not the bad tool). Switch to -32602 (invalid_params, which is what a bad 'name' param actually is) and surface 'Unknown tool: ' so MCP clients get an actionable error.
mpr sweep had no description in --help. Add a clap doc comment so it stops looking like an undocumented hidden command.
Adds 4 regression tests:
cargo fmt clean, clippy -D warnings 0, 424 tests pass.