-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize workflow DB updates #3453
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. The main patch you flagged as the important one is pretty small.
This is done on top of #3450 and #3452; I recommend reviewing and merging those first.
In this PR, only the last commit matters, 8306c4e
I'm not sure if this is going to help, but it's a result of my investigation of performance and the discussion with Claude: trying to avoid upserts, doing separate create and updates.
Btw, I hope that creates and updates happen in order; if they don't, somehow, because the DB locks and a few updates are queued up, and then those are executed in a random order, then we might end up with an older final version of the workflow. If this is the cause of disappearing workflows issue, then at least I added some logging here.