Fix #1118: avoid using "-P" with grep #1121
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default version of `grep` on macOS (at least through macOS 15) does not take a `-P` argument, which causes `check/pytest` to fail due to the call to `grep -P` on line 432: ```shell grep -Pv '^(.\[0m)?[\.FEsx]+(.\[36m)?\s+\[\s*\d+%\](.\[0m)?$' ``` The problem is that `-P` is for using Perl-compatible regular expressions (PCRE), which are not standard in the BSD version of grep that comes with macOS. Switching to grep's extended regex syntax using `-E` resolves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default version of
grepon macOS (at least through macOS 15) does not take a-Pargument, which causescheck/pytestto fail due to the call togrep -Pon line 432:grep -Pv '^(.\[0m)?[\.FEsx]+(.\[36m)?\s+\[\s*\d+%\](.\[0m)?$'The problem is that
-Pis for using Perl-compatible regular expressions (PCRE), which are not standard in the BSD version of grep that comes with macOS. Switching to grep's extended regex syntax using-Eresolves the problem.