Skip to content

Relax the restriction on the bitsize of DirtyOutOfPlaceMontgomeryModMul #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Relax the restriction on the bitsize of DirtyOutOfPlaceMontgomeryModMul #1639

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a220e0
relax the restriction no the bitsize of DirtyOutOfPlaceMontgomeryModMul
NoureldinYosri Apr 30, 2025
aa6d21c
nit
NoureldinYosri Apr 30, 2025
6c5d85a
nit
NoureldinYosri Apr 30, 2025
561b199
format
NoureldinYosri Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 43 additions & 6 deletions qualtran/bloqs/mod_arithmetic/mod_multiplication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,10 +586,14 @@ def __attrs_post_init__(self):
assert self.mod > 1 and self.mod % 2 == 1 # Must be an odd integer greater than 1.

if isinstance(self.mod, int) and isinstance(self.bitsize, int):
assert 2 * self.mod - 1 < 2**self.bitsize, f'bitsize={self.bitsize} is too small'
assert self.mod - 1 < 2**self.bitsize, f'bitsize={self.bitsize} is too small'

if isinstance(self.window_size, int) and isinstance(self.bitsize, int):
assert self.bitsize % self.window_size == 0
assert (self.bitsize + self._add_extra_qubit) % self.window_size == 0

@cached_property
def _add_extra_qubit(self):
return 2 * self.mod - 2 >= 2**self.bitsize

@cached_property
def signature(self) -> 'Signature':
Expand Down Expand Up @@ -656,7 +660,13 @@ def on_classical_vals(
if self.uncompute:
assert (
target is not None
and target == (x * y * pow(2, self.bitsize * (self.mod - 2), self.mod)) % self.mod
and target
== (
x
* y
* pow(2, (self.bitsize + self._add_extra_qubit) * (self.mod - 2), self.mod)
)
% self.mod
)
assert qrom_indices is not None
assert reduced is not None
Expand All @@ -671,20 +681,24 @@ def on_classical_vals(
target = 0
qrom_indices = 0
reduced = 0
for i in range(0, self.bitsize, self.window_size):
for i in range(0, self.bitsize + self._add_extra_qubit, self.window_size):
target, qrom_indices = self._classical_action_window(x >> i, y, target, qrom_indices)

if target >= self.mod:
target -= self.mod
reduced = 1

montgomery_prod = (x * y * pow(2, self.bitsize * (self.mod - 2), self.mod)) % self.mod
montgomery_prod = (
x * y * pow(2, (self.bitsize + self._add_extra_qubit) * (self.mod - 2), self.mod)
) % self.mod
assert target == montgomery_prod
return {'x': x, 'y': y, 'target': target, 'qrom_indices': qrom_indices, 'reduced': reduced}

@cached_property
def _mod_mul_impl(self) -> Bloq:
b: Bloq = _DirtyOutOfPlaceMontgomeryModMulImpl(self.bitsize, self.window_size, self.mod)
b: Bloq = _DirtyOutOfPlaceMontgomeryModMulImpl(
self.bitsize + self._add_extra_qubit, self.window_size, self.mod
)
if self.uncompute:
b = b.adjoint()
return b
Expand All @@ -703,6 +717,11 @@ def build_composite_bloq(
assert qrom_indices is not None
assert reduced is not None

if self._add_extra_qubit:
x = bb.join([x, bb.allocate(1, dtype=QMontgomeryUInt(1))])
y = bb.join([y, bb.allocate(1, dtype=QMontgomeryUInt(1))])
target = bb.join([target, bb.allocate(1, dtype=QMontgomeryUInt(1))])

x, y, target, qrom_indices, reduced = bb.add_from( # type: ignore
self._mod_mul_impl,
x=x,
Expand All @@ -718,6 +737,10 @@ def build_composite_bloq(
return {'x': x, 'y': y}

target = bb.allocate(self.bitsize, QMontgomeryUInt(self.bitsize))
if self._add_extra_qubit:
x = bb.join([x, bb.allocate(1, dtype=QMontgomeryUInt(1))])
y = bb.join([y, bb.allocate(1, dtype=QMontgomeryUInt(1))])
target = bb.join([target, bb.allocate(1, dtype=QMontgomeryUInt(1))])
num_windows = (self.bitsize + self.window_size - 1) // self.window_size
qrom_indices = bb.allocate(
num_windows * self.window_size, QMontgomeryUInt(num_windows * self.window_size)
Expand All @@ -727,6 +750,20 @@ def build_composite_bloq(
x, y, target, qrom_indices, reduced = bb.add_from(
self._mod_mul_impl, x=x, y=y, target=target, qrom_indices=qrom_indices, reduced=reduced
)

if self._add_extra_qubit:
x_arr = bb.split(x) # type: ignore[arg-type]
bb.free(x_arr[0])
x = bb.join(x_arr[1:])

y_arr = bb.split(y) # type: ignore[arg-type]
bb.free(y_arr[0])
y = bb.join(y_arr[1:])

target_arr = bb.split(target) # type: ignore[arg-type]
bb.free(target_arr[0])
target = bb.join(target_arr[1:])

return {'x': x, 'y': y, 'target': target, 'qrom_indices': qrom_indices, 'reduced': reduced}

def build_call_graph(
Expand Down
Loading