Fix type comparisons to use isinstance
#430
Open
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the code used `type(X) == Y` to compare types. Those constructs lead to warnings from `flake8`. It is better to use `isinstance`.
dstrain115
reviewed
Sep 15, 2025
| @@ -596,7 +596,7 @@ def representative_parameters(self) -> 'FermiHubbardParameters': | |||
| def equals_for_rescaling(self, other: 'FermiHubbardParameters') -> bool: | |||
| if not isinstance(other, FermiHubbardParameters): | |||
| return False | |||
| if type(self.layout) != type(other.layout): | |||
| if not isinstance(self.layout, type(other.layout)): | |||
There was a problem hiding this comment.
Are we sure about this one? This has different behavior for subclasses of other.layout.
Same thing with several cases below as well.
There was a problem hiding this comment.
Looking at the code below, I think we can delete this if-block and update line 601 to
if isinstance(self.layout, ZigZagLayout) and isinstance(other.layout, ZigZagLayout):
Other updates below look OK to me.
pavoljuhas
reviewed
Sep 15, 2025
| @@ -601,7 +601,7 @@ def cnot_on_layer( | |||
| cirq.Moment(cirq.CZ.on(qc, qt) for qc, qt in pairs_list), | |||
| cirq.Moment(cirq.H.on_each(pair[1] for pair in pairs_list)), | |||
| ] | |||
| elif type(depolarization_probability) == float: | |||
| elif isinstance(depolarization_probability, float): | |||
There was a problem hiding this comment.
(optional) consider changing to numbers.Real if we'd like to handle np.float32 values.
pavoljuhas
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code used
type(X) == Yto compare types. Those constructs lead to warnings fromflake8because type comparisons should useisinstance.