Fixes request context lost in Infinispan cache get/getasync

[karesti]

• Fixes: Infinispan cache does not propagate request context #48196

[geoand]

My high level question is why are things being done with Context Propagation instead of the way that io.quarkus.cache.redis.runtime.RedisCacheImpl does them?

[karesti]

@geoand when I looked at the code of redis, I was under the impression that is because the client is the quarkus vert.x client, everything was working "automatically" comparing to the infinispan client. My personal issue is that I lack a bit of deep underlying knowledge at this point

[geoand]

Okay, I was hoping that the Infinispan client had a Vert.x version... I know we can't do that now, but at some point we really should look into that.

[karesti]

@cescoffier does this seem good ?

[cescoffier]

Should we use the duplicated context instead of context propagation?
I'm not sure if it would fix the issue, but I think it's worth trying.

In this case, you would need to create an executor at the beginning of each method:

var context = Vertx.currentContext();
var executor = r -> {
  if (context == null) r.run();
  else context.runOnContext(x -> r.run());
}

(Avoid the lambdas in the real code)

Then, before returning the Uni:

.emitOn(executor);

[karesti]

Should we use the duplicated context instead of context propagation? I'm not sure if it would fix the issue, but I think it's worth trying.

In this case, you would need to create an executor at the beginning of each method:

var context = Vertx.currentContext();
var executor = r -> {
  if (context == null) r.run();
  else context.runOnContext(x -> r.run());
}

(Avoid the lambdas in the real code)

Then, before returning the Uni:

.emitOn(executor);

I tested and runned into the Suppressed: jakarta.enterprise.context.ContextNotActiveException: RequestScoped context was not active when trying to obtain a bean instance for a client proxy of CLASS bean [class=io.quarkus.it.cache.infinispan.ClientRequestService, id=VcMhAzqfwnRsjHRm80Y_wUxTmRc]
1653

[karesti]

@cescoffier thanks for all your insights and help, let me know now

[cescoffier]

It would have been nice to replace the lambdas

[karesti]

@cescoffier I removed the lambdas

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9936f54.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[cescoffier]

Added the backport-3.20 label to investigate if it's possible or not.
(I know that 3.20 is frozen, so it will be in the next one)

CC @karesti