Skip to content

Conversation

fjuma
Copy link
Collaborator

@fjuma fjuma commented Sep 15, 2025

No description provided.

Copy link

github-actions bot commented Sep 15, 2025

🎊 PR Preview 9d1e899 has been successfully built and deployed to https://quarkus-site-pr-2404-preview.surge.sh

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAde some comment on the API, nothing blocking.

public AgentCard agentCard() {
return new AgentCard.Builder()
.url(YOUR_HTTP_JSON_URL) <1>
.preferredTransport(TransportProtocol.HTTP_JSON.asString()) <2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS it really preferred? What if it's not compatible with the URL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create an issue to make sure we validate this.

@kabir ^ FYI.

.preferredTransport(TransportProtocol.HTTP_JSON.asString()) <2>
.additionalInterfaces(List.of(
new AgentInterface(TransportProtocol.HTTP_JSON.asString(),
YOUR_HTTP_JSON_URL) <3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that what is used in the case of negotiation? If so, why do I have to repeat it? (The order could be used, no?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we specify the transport and the URL combinations that are supported by the server and their order.

It's not strictly required to repeat the preferred transport here (since it will be added automatically by the AgentCard.Builder() if it's not specified by the user). I'll tweak the description here to mention that it's optional.

However, any other transports the server will support must be specified here. What repetition/order are you referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants