-
Notifications
You must be signed in to change notification settings - Fork 394
Add a blog post about the A2A Java SDK 0.3.0.Beta1 release #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
82be0b7
to
1698187
Compare
🎊 PR Preview 9d1e899 has been successfully built and deployed to https://quarkus-site-pr-2404-preview.surge.sh
|
1698187
to
bfe21f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAde some comment on the API, nothing blocking.
public AgentCard agentCard() { | ||
return new AgentCard.Builder() | ||
.url(YOUR_HTTP_JSON_URL) <1> | ||
.preferredTransport(TransportProtocol.HTTP_JSON.asString()) <2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IS it really preferred? What if it's not compatible with the URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create an issue to make sure we validate this.
@kabir ^ FYI.
.preferredTransport(TransportProtocol.HTTP_JSON.asString()) <2> | ||
.additionalInterfaces(List.of( | ||
new AgentInterface(TransportProtocol.HTTP_JSON.asString(), | ||
YOUR_HTTP_JSON_URL) <3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that what is used in the case of negotiation? If so, why do I have to repeat it? (The order could be used, no?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where we specify the transport and the URL combinations that are supported by the server and their order.
It's not strictly required to repeat the preferred transport here (since it will be added automatically by the AgentCard.Builder()
if it's not specified by the user). I'll tweak the description here to mention that it's optional.
However, any other transports the server will support must be specified here. What repetition/order are you referring to?
bfe21f1
to
ed951a9
Compare
No description provided.