-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiments: Add possible suggestion to the empty results response #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature seems nice, +1 to add it.
A few comments below though :)
c811710
to
c62ebbc
Compare
f11b6cb
to
5a4161d
Compare
5a4161d
to
8a870b6
Compare
Ready to merge, then? :) |
8a870b6
to
93891e5
Compare
rebased the pr, but let's get the relevance PR in first (#402) |
@marko-bekhta / @yrodiere is there a stage instance I could play with? |
93891e5
to
61b26e5
Compare
There is, but it's based on I guess we will soon enough, Marko is trying to get CI to pass :) |
61b26e5
to
2b2b580
Compare
yeah 😄 those not sorted imports ... 😄 |
I checked the code and this could fix my #306 concern. Maybe the tests could cover cases mentioned in the issue. Or I can add them later. It's up to you guys :) |
2b2b580
to
c8a542b
Compare
Added a few more test queries, including the missing ones from the ticket description 😃; let's see if the build will pass on CI 🤞🏻 |
c8a542b
to
04eca33
Compare
Fixes #306
Hey @yrodiere
I was going through some tickets at HSEARCH 😃 and noticed one submitted by the community about suggesters, but without much info. Hence, I thought I'd take a closer look at the suggesters before closing the ticket 🙈 and it turned out to be an interesting feature. This PR tests how we could leverage from it in search.quarkus.io.
While at it, I thought: should we give users a way to manipulate the request JSON before we send it (like in this PR we are adding another top-level element to the JSON, so adding things through e.g. a JSON predicate, wouldn't really work...)
Some links: