Adjust the condition of not returning index.html #398
Merged
+39
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
approved these changes
Jan 28, 2025
that should be doable ... let me update the PR 😃 |
marko-bekhta
force-pushed
the
fix/make-ui-available-for-staging
branch
from
ad6d459 to
9ce0b6a
Compare
marko-bekhta
commented
Jan 28, 2025
To rely on an application property that disables the UI in the prod profile
marko-bekhta
force-pushed
the
fix/make-ui-available-for-staging
branch
from
9ce0b6a to
505fc5f
Compare
yrodiere
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to not rely on launch mode but on profiles instead. This way staging, that also runs in a normal launch mode can benefit from the index search page