zlog: fix incorrect escaping logic #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
approved these changes
Jul 11, 2025
Contributor
crozzy
left a comment
crozzy
left a comment
There was a problem hiding this comment.
LGTM, just one nit, took me a while to page back in char encoding semantics...
The previous way of doing this was (purposefully! there was a test!) inserting invalid characters into values. This does the percent-encoding in one spot, instead of doing a second pass that can introduce disallowed characters. See-also: quay/claircore#1582 Signed-off-by: Hank Donnay <[email protected]>
hdonnay
force-pushed
the
bug/baggage-encoding
branch
from
90c8d7a to
08a589d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous way of doing this was (purposefully! there was a test!) inserting invalid characters into values. This does the percent-encoding in one spot, instead of doing a second pass that can introduce disallowed characters.
See-also: quay/claircore#1582