Adding decimal to documentation #242
Conversation
|
🚀 Build success! Latest successful preview: https://preview-242--questdb-documentation.netlify.app/docs/ Commit SHA: 0632722
|
|
|
||
| - `nanRate` is an `int` defining the frequency of occurrence of `NaN` values: | ||
| - `0`: No `NaN` will be returned. | ||
| - `1`: Will only return `NaN`. |
There was a problem hiding this comment.
This is not factual! I think it has been broken for a while also on other rnd generators as not the first time I see this. But if you execute with 1 you will see it returns only some nan, not all
There was a problem hiding this comment.
Probably this should be fixed in code, rather than on docs
There was a problem hiding this comment.
@puzpuzpuz I think the problem comes from the + 1 here, do you happen to know why it's there?
There was a problem hiding this comment.
I'm not aware of the initial reason to approach null rate like this in the random functions, but changing this would be a breaking change.
There was a problem hiding this comment.
It would be a breaking change for other types, the decimal type hasn't been released yet.
There was a problem hiding this comment.
This is the only pending point on my end to approve. If you agree this is not a decimal issue, but a problem with the current implementation, I am happy to approve
There was a problem hiding this comment.
The documentation doesn't make sense with the current implementation, we should change one of them.
There was a problem hiding this comment.
Agreed. I am just not sure if the current behaviour is something we want to document, as I am not sure what it does
There was a problem hiding this comment.
guess we can just approve, seeing as this is a wider problem and not related to decimal. The day (if any) it gets fixed for all other types, it will be fixed for decimal as well
3 participants
This PR adds the documentation to use the decimal type in QuestDB.
Related PR: #6068
TODO
Optional