Skip to content

Add support for overriding the mime.types file #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for overriding the mime.types file #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a825522
Add support for overriding the mime.types file
wkbrd Oct 6, 2025
f52258e
Add mimeConfig enable check per PR comment
wkbrd Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/questdb/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,12 @@ Generate log.conf file content
{{ $key }} = {{ $value }}
{{- end }}
{{- end }}

{{/*
Generate mime.types file content
*/}}
{{- define "generateMimeConfig" -}}
{{- range $key, $value := index .Values.questdb.mimeConfig.options }}
{{ $key }} {{ $value }}
{{- end }}
{{- end }}
9 changes: 8 additions & 1 deletion charts/questdb/templates/config.yaml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .Values.questdb.mimeConfig.enabled check on line 1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. Thank you

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if or .Values.questdb.serverConfig.enabled .Values.questdb.loggingConfig.enabled -}}
{{- if or .Values.questdb.serverConfig.enabled .Values.questdb.loggingConfig.enabled .Values.questdb.mimeConfig.enabled -}}
apiVersion: v1
{{- if eq .Values.questdb.configStorageType "Secret" }}
kind: Secret
Expand All @@ -18,6 +18,9 @@ data:
{{- if .Values.questdb.loggingConfig.enabled }}
log.conf: {{ include "generateLogConfig" . | b64enc -}}
{{- end }}
{{- if .Values.questdb.mimeConfig.enabled }}
mime.types: {{ include "generateMimeConfig" . | b64enc -}}
{{- end }}
{{- else }}
data:
{{- if .Values.questdb.serverConfig.enabled }}
Expand All @@ -28,5 +31,9 @@ data:
log.conf: |
{{- include "generateLogConfig" . | nindent 4 -}}
{{- end }}
{{- if .Values.questdb.mimeConfig.enabled }}
mime.types: |
{{- include "generateMimeConfig" . | nindent 4 -}}
{{- end }}
{{- end }}
{{- end }}
15 changes: 15 additions & 0 deletions charts/questdb/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ spec:
mountPath: {{ .Values.questdb.dataDir }}/conf/log.conf
subPath: log.conf
{{- end }}
{{- if .Values.questdb.mimeConfig.enabled }}
- name: mime-config
mountPath: {{ .Values.questdb.dataDir }}/conf/mime.types
subPath: mime.types
{{- end }}
{{- if .Values.extraVolumeMounts }}
{{ toYaml .Values.extraVolumeMounts | nindent 10 }}
{{- end }}
Expand Down Expand Up @@ -148,6 +153,16 @@ spec:
name: {{ include "questdb.fullname" . }}
{{- end }}
{{- end }}
{{- if .Values.questdb.mimeConfig.enabled }}
- name: mime-config
{{- if eq .Values.questdb.configStorageType "Secret" }}
secret:
secretName: {{ include "questdb.fullname" . }}
{{- else }}
configMap:
name: {{ include "questdb.fullname" . }}
{{- end }}
{{- end }}
- name: migration-scripts
configMap:
name: {{ include "questdb.fullname" . }}-db-migrations
Expand Down
3 changes: 3 additions & 0 deletions charts/questdb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ questdb:
loggingConfig:
enabled: false
options: {}
mimeConfig:
enabled: false
options: {}
# env supports key/value pairs that are added directly to the questdb statefulset's env
env: {}
# envFrom supports a list of sources that will be injected into the questdb statefulset's env
Expand Down