feat: migrate QueueITLib to Swift #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified .gitignore and Package.swift - Deleted old Objective-C files from QueueITLib - Added new Swift files to Sources/QueueITLib
Removed redundant return types from methods in QueueItEngine and QueueITWaitingRoomProvider classes. This change simplifies the code by eliminating unnecessary return statements.
Renamed various files and classes to improve naming consistency across the project. Updated references in the README.md and source files to reflect these changes. This includes renaming classes like QueueITApiClient to ApiClient, QueueITWaitingRoomProvider to WaitingRoomProvider, and others.
alexanderthoren
force-pushed
the
master
branch
5 times, most recently
from
796363e to
e3297d4
Compare
Make WaitingRoomProvider and WaitingRoomView classes and their protocols publicly accessible to enable external usage of the SDK components.
- Upgrade swift-tools-version to 6.0 in Package.swift - Update iOS deployment target to v15 - Refactor ApiClient to use async/await - Remove Connection and ConnectionRequest classes - Add @mainactor annotations to relevant methods - Ensure Status struct conforms to Sendable - Update various protocols and methods to use async/await
…nd Task wrapper - Add @mainactor annotation for thread safety - Change tryPass to be non-throwing and non-async - Wrap async call in Task for better concurrency handling
- Replace legacy decidePolicyFor callback pattern with modern async/await version - Update UIApplication.open call to be async - Return navigation policy and webpage preferences tuple instead of using completion handler Signed-off-by: alexanderthoren <[email protected]>
- Make queueUrl, targetUrl and queueToken non-optional in TryPassResult - Update QueueITEngine and WaitingRoomProvider to handle non-optional values - Remove unnecessary optional handling in showQueue method - Simplify getUserId call by removing async keyword
Previously the WebView had a transparent background which could cause visual issues. Setting it to white provides a cleaner, more consistent appearance.
…_white style(webview): change WebView background color to white
…pe safety - Combine all queue delegate protocols into single QueueItEngineDelegate - Remove unnecessary optional string parameters from delegate methods - Improve error handling by passing actual error messages - Simplify delegate management in QueueItEngine class
refactor(queue-engine): consolidate delegate protocols and improve type safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
What does this PR do?
Changes
Tech debt
Maybe I will take a look into these in the short future as I want to contribute to more open source projects.