Conversation
Add GitHub action to be used by QUIC implementations to run the QUIC Interop Runner in their CI.
This reverts commit 9f7a74d.
There was a problem hiding this comment.
This workflow will only execute once it is merged into master. In other words, once it is merged, a comment will appear on all future pull requests.
|
@marten-seemann can you give this pull request a review? I would like to use this GitHub Action in Neqo as a first smoke-test to prevent regressions. See mozilla/neqo#1682. As it is today it could have caught mozilla/neqo#1676, mozilla/neqo#1627 and mozilla/neqo#1578. In addition, I plan to make some larger changes to Neqo's Interop binary (mozilla/neqo#1696, mozilla/neqo#1693). Instead of running the test manually on each iteration, this action would save me a lot of manual testing. Mozilla has an allow-list for GitHub Actions (see mozilla/neqo#1682 (comment)). The process of allowing a new Action (e.g. this one), seems to take a bit (https://bugzilla.mozilla.org/show_bug.cgi?id=1883011). In quic-go/quic-go#4339 (comment) you suggest parallelizing the testcase execution. I am not very familiar with the internals of the QUIC Interop Runner yet, but on a high level that sounds good to me. Still, given that this action could already be helpful in Neqo and given that the Mozilla Action approval process takes a bit, would you be opposed to merging a first version of this action without additional features (e.g. parallelization)? Edit: We decided to clone the action within mozilla/neqo for now (see mozilla/neqo#1682). Thus this just became less time critical. |
This reverts commit 163cca4.
For now until quic-interop/quic-interop-runner#356 is merged.
* feat(.github): run QUIC Interop Runner Run the QUIC Interop Runner testcases on pull requests when entering the merge queue. * Do not always construct comment * Test for all pull requests to main * Don't build arm64 on pull requests * Use actions/download-artifact * Provide client, server and test argument * Fix action args * Copy action into neqo repo For now until quic-interop/quic-interop-runner#356 is merged. * checkout * yml * introduce folder * load image * Only run interop on pull requests * Remove pull_request path filter * Trigger CI * Cache Python deps * Trigger CI to test python cache
|
we've implemented similar in our own |
|
The code in this PR may be stale; the latest is at https://github.com/mozilla/neqo/blob/main/.github/actions/quic-interop-runner/action.yml |
3 participants
Add GitHub action to be used by QUIC implementations to run the QUIC Interop Runner in their CI.