Maintain the right order of client/server while exporting the results to JSON#391
Merged
marten-seemann merged 1 commit intoquic-interop:masterfrom May 24, 2024
Merged
Conversation
Contributor
Author
|
The interop run that I had triggered last evening completed and the change proposed in this PR has fixed the issue - the result.json now has the content which is correctly ordered. |
marten-seemann
approved these changes
May 24, 2024
Collaborator
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
Thank you @jaikiran!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue noted in #390.
The root cause of this issue that the in the change here #355, we introduced the use of a
set()for clients and servers https://github.com/quic-interop/quic-interop-runner/pull/355/files#diff-a1f0ac428938a846f118f59aa8e2e66b90bff7b498b928204eb3bfcb41f1f528R245, which cause the clients/servers to be potentially in a different order than the iteration order that we use later a few lines below https://github.com/quic-interop/quic-interop-runner/pull/355/files#diff-a1f0ac428938a846f118f59aa8e2e66b90bff7b498b928204eb3bfcb41f1f528R267.The commit in this PR, addresses that by changing the iteration logic to iterate in the same order as that of the
clients,serversthat were constructed as aset(). I have triggered a interop run on my system to verify this actually fixes the issue. I will check out the results tomorrow.