feat: Run testcases in parallel#448
Open
larseggert wants to merge 3 commits intoquic-interop:masterfrom
Open
Conversation
This PR lets testcases run in parallel to speed up things. On my Mac, 16 parallel tests take 196.31 seconds instead of 645.86 seconds with `--parallel 1`. The main changes here are to allocate sepearate subnets for each testcase run, so Docker can keep them separated. We also need to pass that network configration into the simulator via environment variables. We're also collecting log messages during the tests and print them after a test ends, to reduce interleaved output. Depends on quic-interop/quic-network-simulator#143
Collaborator
|
This seems like a pretty massive change. Not sure if it’s worth it for just a 3x speed up. The interop runner is primarily designed to be run as a cron job (and in CI), and we certainly don’t care for that use case. |
Contributor
Author
|
I can get the entire run down to 148.23 sec with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets testcases run in parallel to speed up things. On my Mac, 16 parallel tests take 196.31 seconds instead of 645.86 seconds with
--parallel 1.The main changes here are to allocate sepearate subnets for each testcase run, so Docker can keep them separated. We also need to pass that network configration into the simulator via environment variables.
We're also collecting log messages during the tests and print them after a test ends, to reduce interleaved output.
Depends on quic-interop/quic-network-simulator#143