Add Glm4MoeForCausalLM Support #619
Open
+459
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shagsood <[email protected]>
Signed-off-by: shagsood <[email protected]>
Signed-off-by: shagsood <[email protected]>
Signed-off-by: shagsood <[email protected]>
quic-shagun
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Contributor
|
@shagsood do we have approval for this model? also do add this model under validated model list |
Contributor
|
@vbaddi can you please review this PR? |
Yes we have legal approval for this model. |
vbaddi
requested changes
Nov 19, 2025
|
|
||
| class QEffGlm4MoeMoE(Glm4MoeMoE): | ||
| """ | ||
| MoE Block |
Contributor
There was a problem hiding this comment.
nit: We can start using our optimized moe block for prefill/decode usecase here?
Contributor
Author
There was a problem hiding this comment.
Is there a specific PR I need to refer for this?
asmigosw
suggested changes
Dec 5, 2025
| key_states, | ||
| value_states, | ||
| attention_mask, | ||
| dropout=0.0 if not self.training else self.attention_dropout, |
Contributor
There was a problem hiding this comment.
Can we remove this dropout, since we are not using it in eager_attention_forward
| value: torch.Tensor, | ||
| attention_mask: Optional[torch.Tensor], | ||
| scaling: float, | ||
| dropout: float = 0.0, |
Contributor
There was a problem hiding this comment.
Please remove, since its not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for zai-org/GLM-4.5-Air model.
Open source MoE model with performance and accuracy better than many closed source models: