Improve mock #723
Improve mock #723
Conversation
| static Connection* makeMockConnection(const QString& mxId, | ||
| bool enableEncryption = E2EE_Enabled); | ||
|
|
||
| static Connection* makeMockConnection(Connection *connection, const QString& mxId, |
There was a problem hiding this comment.
this API looks weird, why is it a static function that's passed an object?
Looking at the neochat MR for this, it seems that we could easily use the existing makeMockConnection function
There was a problem hiding this comment.
the issue with the existing function is that it return a Connection * and not a NeoChatConnection *
There was a problem hiding this comment.
AccountRegistry looks like a good place for it? Then you could derive from it and override a virtual function. Or simply making makeMockConnection() a template would also work I guess (would need pulling completeSetup() from Connection::Private to Connection but that's a smaller evil)?
| Room* provideRoom(const QString& roomId, | ||
| Omittable<JoinState> joinState = none); | ||
|
|
||
| //! Add room to the connection |
There was a problem hiding this comment.
Please also mention that this is only for tests and not useful in normal operation
No description provided.