Upstream HtmlFilter facilities from Quaternion #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KitsuneRal
force-pushed
the
kitsune/htmlfilter
branch
6 times, most recently
from
335b46c to
61605b0
Compare
Produces a QRegularExpression object. You still should store it in a static variable unless you are using it no more than once throughout the program run time; but at least that static variable definition becomes more compact (`static const auto re = "...."_qre;`).
Most of HtmlFilter have been written as wall-of-code functions without much of separation into logical parts. This commit tries to address this, factoring out some of the code into dedicated functions and restructuring filterTag() into ElementFilter class.
KitsuneRal
force-pushed
the
kitsune/htmlfilter
branch
from
61605b0 to
4547951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality is complete (it's exactly the same code that Quaternion has been using since 0.0.96, save for the namespace change) but there are no tests for it yet.