Skip to content

Cleanup and minor fixes #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 2, 2025
Merged

Cleanup and minor fixes #884

merged 6 commits into from
May 2, 2025

Conversation

KitsuneRal
Copy link
Member

...before merging dev into #820

KitsuneRal added 6 commits May 2, 2025 16:27
@KitsuneRal
Replace template parameteres with auto where applicable
34ec8a9
@KitsuneRal
ranges_extras.h: make sure all algorithms are constexpr inline
76db61a
@KitsuneRal
Extend rangeTo() to work with more containers
e973158 
Upcoming rust::Vec cannot be initialised from a pair of iterators,
neither from a range; but std::ranges::to() knows how to handle that,
too. And now rangeTo() does, too.
@KitsuneRal
connection.cpp: unify and fix Qt Keychain jobs handling
1c64e9d 
In particular, fixed copy-pasta due to which the outcome of the pickle
job has never been checked; and connecting to the job after it started,
which may not work if the job completes synchronously.
@KitsuneRal
RequestData: make helper names more specific
d0304c6 
fromJson() could be confused with converters' fromJson() although the
two have nothing to do with each other.
@KitsuneRal
QUO_CHECK: avoid GCC warning about unused bool value
f9f2de1
@github-project-automation github-project-automation bot moved this to In work in libQuotient 1 May 2, 2025
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label May 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
82.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KitsuneRal KitsuneRal merged commit 4fd1d8e into dev May 2, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In work to 0.10 - Done in libQuotient 1 May 2, 2025
@KitsuneRal KitsuneRal deleted the kitsune/cleanup branch May 2, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiasFella TobiasFella TobiasFella approved these changes

Assignees

No one assigned

Labels

enhancement A feature or change request for the library

Projects

libQuotient 1
Status: 0.10 - Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KitsuneRal @TobiasFella