Unstable event types #922
Open
Unstable event types #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we could use unstable event types with a bit more comfort.
They still don't have std::ranges::contains().
This commit drops the "feature" of providing extra text instead of a Matrix type id for base events. This has been a hack from the very beginning, not really used aside from log lines at application startup.
|
As suggested by Sonar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to provide two event types for a given event class in
QUO_EVENT- normally one will be stable and another unstable. No new event types are introduced, except extendingCustomEventin Quotest in order to test the functionality.