Skip to content

RoomEvent: Cache event id #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

RoomEvent: Cache event id #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Quotient/events/roomevent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

using namespace Quotient;

RoomEvent::RoomEvent(const QJsonObject& json) : Event(json)
RoomEvent::RoomEvent(const QJsonObject &json) : Event(json), _id(fullJson()[EventIdKey].toString())
{
if (const auto redaction = unsignedPart<QJsonObject>(RedactedCauseKey);
!redaction.isEmpty())
Expand All @@ -22,7 +22,7 @@ RoomEvent::~RoomEvent() = default; // Let the smart pointer do its job

QString RoomEvent::displayId() const { return id().isEmpty() ? transactionId() : id(); }

QString RoomEvent::id() const { return fullJson()[EventIdKey].toString(); }
QString RoomEvent::id() const { return _id; }

QDateTime RoomEvent::originTimestamp() const
{
Expand Down Expand Up @@ -79,6 +79,7 @@ void RoomEvent::addId(const QString& newId)
Q_ASSERT(id().isEmpty());
Q_ASSERT(!newId.isEmpty());
editJson().insert(EventIdKey, newId);
_id = newId;
qCDebug(EVENTS) << "Event txnId -> id:" << transactionId() << "->" << id();
Q_ASSERT(id() == newId);
}
Expand Down
2 changes: 2 additions & 0 deletions Quotient/events/roomevent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ class QUOTIENT_API RoomEvent : public Event {
void dumpTo(QDebug dbg) const override;

private:
QString _id;

// RedactionEvent is an incomplete type here so we cannot inline
// constructors using it and also destructors (with 'using', in particular).
event_ptr_tt<RedactionEvent> _redactedBecause;
Expand Down