CompatHelper: bump compat for LinearSolve to 3, (keep existing compat) #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
albertomercurio
force-pushed
the
compathelper/new_version/2025-02-06-06-39-24-586-02154681237
branch
from
b373092 to
975944e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 93.59% 87.15% -6.45%
==========================================
Files 44 45 +1
Lines 2826 3152 +326
==========================================
+ Hits 2645 2747 +102
- Misses 181 405 +224 ☔ View full report in Codecov by Sentry. |
|
I think this dependency issue will be solved after the following PR is merged: |
|
Also need to wait for them to bump the new version of |
ytdHuang
approved these changes
Feb 11, 2025
|
We first need SciML/LinearSolve.jl#573 to be resolved. |
The circular dependency issue has been solved. I also fixed the code quality issue directly in this PR (since it's a reasonable small change). |
albertomercurio
approved these changes
Feb 13, 2025
ytdHuang
deleted the
compathelper/new_version/2025-02-06-06-39-24-586-02154681237
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
LinearSolvepackage from2to2, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.