Add some generic pipes (when specific values are unknown). #325
Conversation
I don't speak RO so feel free to fix the translation (I wrote the `value_ro` in english).
nicolas-sitylb
changed the title
value_lists/vl_pipe_material.sql
Outdated
| @@ -561,6 +562,7 @@ INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (7628, true, '', '', 'PE80', 'Polyéthylène 80', 'PE80', 'Polietilenă 80', '710', NULL, 625.800, 710.000, 8, 17, 42.1); | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (7629, true, '', '', 'PE80', 'Polyéthylène 80', 'PE80', 'Polietilenă 80', '90', NULL, 81.400, 90.000, 6, 21, 4.3); | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (7630, true, '', '', 'PE80', 'Polyéthylène 80', 'PE80', 'Polietilenă 80', '110', NULL, 99.400, 110.000, 6, 21, 5.3); | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (9999, true, '', '', 'PE inconnu', 'Polyéthylène de type inconnu', 'PE unknown', 'Polietilenă unknown type', NULL, NULL, NULL, NULL, NULL, NULL, NULL); | |||
There was a problem hiding this comment.
Hi - by consistency of serial id, maybe 7699 would be a bette id value? Polyéthylène is all in the 7xxx range
There was a problem hiding this comment.
Do you have a description of those different ranges, I can guess most of them, but I do not like "guessing" stuff. ;-)
There was a problem hiding this comment.
nope, I don't know of any specification for id ranges.
There was a problem hiding this comment.
@3nids Do you know how the id's were set at the beginning?
There was a problem hiding this comment.
@nicolas-sitylb For PE we already have id 5501 who takes care of the unknown value. I think your PR should update those values to "unknown etc."
You can replace the Ro value from 'Polietilenă unknown type' with PE necunoscută
Thank you!
There was a problem hiding this comment.
What I see here is that we have two PE with unknown diameters :
- 1st is id 5501 for PE (100) with unknown diameter.
- 2nd is id 5550 for PE 80 with unknown diameter.
I would not be in favor of adding an unknown PE material, since "plastic" generic material type is a synonym of PE unknown. In that case it would be better to use either
- 3rd id 5651 plastic with unknown diameter
or - 1st id 5501 for PE (100) with unknown diameter as default value when PE type is unknown.
There was a problem hiding this comment.
Hi, I always took the plastic as also containing PVC or GRP. If we differentiate between PE(100) and PE80 then we should also differentiate the unknown values.
value_lists/vl_pipe_material.sql
Outdated
| @@ -561,6 +562,7 @@ INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (7628, true, '', '', 'PE80', 'Polyéthylène 80', 'PE80', 'Polietilenă 80', '710', NULL, 625.800, 710.000, 8, 17, 42.1); | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (7629, true, '', '', 'PE80', 'Polyéthylène 80', 'PE80', 'Polietilenă 80', '90', NULL, 81.400, 90.000, 6, 21, 4.3); | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (7630, true, '', '', 'PE80', 'Polyéthylène 80', 'PE80', 'Polietilenă 80', '110', NULL, 99.400, 110.000, 6, 21, 5.3); | |||
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (9999, true, '', '', 'PE inconnu', 'Polyéthylène de type inconnu', 'PE unknown', 'Polietilenă unknown type', NULL, NULL, NULL, NULL, NULL, NULL, NULL); | |||
There was a problem hiding this comment.
Therefore:
| INSERT INTO qwat_vl.pipe_material (id, vl_active, short_en, value_en, short_fr, value_fr, short_ro, value_ro, diameter, diameter_nominal, diameter_internal, diameter_external, pressure_nominal, sdr, wall_thickness) VALUES (9999, true, '', '', 'PE inconnu', 'Polyéthylène de type inconnu', 'PE unknown', 'Polietilenă unknown type', NULL, NULL, NULL, NULL, NULL, NULL, NULL); |
Update the Romanian translation according to: qwat#325 (comment)
|
@tudorbarascu I updated the Romanian translation according to your proposal. |
Notice: I don't speak RO so feel free to fix the translation (I wrote the extra suffix in
value_roin english).