fix: change popover position to fixed to resolve position issues in absolute layouts #1114
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c7f2213 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
ignatvilesov
force-pushed
the
popover-fixed-position
branch
2 times, most recently
from
d8bef2a to
0424d41
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
ignatvilesov
force-pushed
the
popover-fixed-position
branch
from
0424d41 to
c7f2213
Compare
|
@shairez Hey Shai 👋 I hope you're well. It would nice if you could review this tiny PR whenever you have some free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
Popoveris positioned incorrectly in absolute scrollable containers like virtual tables.Before
After
Checklist:
pnpm changeand documented my changes