Skip to content

A/13 challenge #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 02_challenge/02_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ def fizzbuzz(max_num):

#----START OF SCRIPT
if __name__=='__main__':
fizzbuzz()
fizzbuzz(9)
2 changes: 2 additions & 0 deletions 02_challenge/02_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Completed the task
while executing I should get either Fizz or Buzz, I am getting both result when I try with multiples of 3 or 5
4 changes: 2 additions & 2 deletions 03_challenge/03_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
def fizzbuzz(max_num):
"This method implements FizzBuzz"
# Google for 'range in python' to see what it does
for i in range(1,max_num):
for i in range(55):
# % or modulo division gives you the remainder
if i%3==0 and i%5==0:
print(i,"fizzbuzz")
Expand All @@ -23,4 +23,4 @@ def fizzbuzz(max_num):

#----START OF SCRIPT
if __name__=='__main__':
fizzbuzz('16')
fizzbuzz('15')
2 changes: 2 additions & 0 deletions 03_challenge/03_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
changed the string value to 55 from (1,max_num)
Task completed
6 changes: 3 additions & 3 deletions 04_challenge/04_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ def fizzbuzz(max_num):
for i in range(1,max_num):
# % or modulo division gives you the remainder
if i%num1==0 and i%num2==0:
print(i,three_mul+five_mul)
print(i,"three_mul+five_mul")
elif i%num1==0:
print(i,three_mul)
print(i,"three_mul")
elif i%num2==0:
print(i,five_mul)
print("i,five_mul")

#----START OF SCRIPT
if __name__=='__main__':
Expand Down
2 changes: 2 additions & 0 deletions 04_challenge/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
aligned the line 26 print
completed the task
6 changes: 4 additions & 2 deletions 05_challenge/05_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ def fizzbuzz(max_num):
# we will make our script 'tighter' in one of coming exercises
three_mul = 'fizz'
five_mul = 'buzz'
with open('mifile.txt','r') as f:
print 'i have created'

with open("myfile.txt",'r') as f:
print(f,"i have created")
print ("i have created")
num1 = int(f.readline())
num2=int(f.readline())
max_num = int(f.readline())
Expand Down
2 changes: 1 addition & 1 deletion 06_challenge/06_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def fizzbuzz(max_num):
three_mul = 'fizz'
five_mul = 'buzz'
num1 = conf.num1
num2 = conf.num
num2 = conf.num2
# Google for 'range in python' to see what it does
for i in range(1,max_num):
# % or modulo division gives you the remainder
Expand Down
3 changes: 3 additions & 0 deletions 06_challenge/06_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changed the num attribute to Num1 and Num2
Attribute error gave me the hint
Task completed
2 changes: 1 addition & 1 deletion 07_challenge/07_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ def fizzbuzz(max_num):

#----START OF SCRIPT
if __name__=='__main__':
fizzbuzz(99)
fizzbuzz(100)
2 changes: 2 additions & 0 deletions 07_challenge/07_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Checked the challenge hint
verified the fizzbuzz string and changed to (100)
2 changes: 1 addition & 1 deletion 08_challenge/08_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
class Fizz_Buzz:
"Class to implement FizzBuzz for multiples of 3 and 5"

def fizzbuzz(max_num):
def fizzbuzz(self, max_num):
"This method implements FizzBuzz"

# adding some redundant declarations on purpose
Expand Down
2 changes: 2 additions & 0 deletions 08_challenge/08_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Used the hint
since one argument is enough, removed the second argument
2 changes: 1 addition & 1 deletion 09_challenge/09_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def fizzbuzz(max_num):
num2 = 5

# Google for 'range in python' to see what it does
for i in range(6,max_num):
for i in range(3,max_num):
# % or modulo division gives you the remainder
if i%num1==0 and i%num2==0:
print(i,three_mul+five_mul)
Expand Down
2 changes: 2 additions & 0 deletions 09_challenge/09_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Changed the range to 3
Hint helped me find the error
6 changes: 3 additions & 3 deletions 13_challenge/13_challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ def fizzbuzz(max_num):

# adding some redundant declarations on purpose
# we will make our script 'tighter' in one of coming exercises
three_mul = 'fizz
three_mul ='fizz'
five_mul = 'buzz'
num1 = 3
num2 = 5

# Google for 'range in python' to see what it does
for i in range(1,max_num)
for i in range(1,max_num):
# % or modulo division gives you the remainder
if i%num1==0 and i%num2==0:
print(i,three_mul+five_mul)
Expand All @@ -31,4 +31,4 @@ def fizzbuzz(max_num):

#----START OF SCRIPT
if __name__=='__main__':
fizzbuzzy(100)
fizzbuzz(100)