Support case where specified method ignores mode in download_linter() #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 128 128
Lines 7143 7160 +17
=======================================
+ Hits 7091 7108 +17
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -40,14 +40,36 @@ download_file_linter <- function() { | |||
|
|
|||
| implicit_mode <- is.na(download_file_mode) | |||
|
|
|||
| # According to download.file() documentation, mode is ignored when method | |||
There was a problem hiding this comment.
include a corresponding example?
R/download_file_linter.R
Outdated
| following-sibling::expr[1]/STR_CONST | ||
| " | ||
| ) | ||
| no_mode_method <- !is.na(download_file_method) & download_file_method %in% c("wget", "curl") |
There was a problem hiding this comment.
naming suggestion: has_ignored_mode or method_ignores_mode. Particularly would like to avoid !no double-negation
| # mode explicitly specified with a method that ignores it | ||
| lint_message <- rex::rex("mode argument value is ignored") | ||
| expect_lint("download.file(x, method = 'wget', mode = 'w')", lint_message, linter) | ||
| expect_lint("download.file(x, method = 'curl', mode = 'wb')", lint_message, linter) |
There was a problem hiding this comment.
add a test where method=method, i.e., given as a name not a character literal, as well as an explicit setting outside these, e.g. method="internal".
MichaelChirico
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2882