-
Notifications
You must be signed in to change notification settings - Fork 0
chore: upgrade to stable2409 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
al3mart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look alright! Thanks!
If anything, given that we are introducing revive, it might make sense pointing in the README that users need to deploy this proxy server:
Which emulates the Ethereum Json RPC. So that's the server eth dapps and wallets want to connect to instead of the node directly.
Also this is the REMIX version that should be used:
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! One thing before merging: please remove the network.toml file, as pop-cli generates it automatically. For future reference, it might be a good idea to add a line to .gitignore to prevent this in the future.
I was able to manually deploy a contract using pallet_revive. However, until pop-cli is fully compatible, it might not be worth adding too much detail about revive in the README. Perhaps just include a note for developers mentioning that the template includes pallet_revive and pallet_contracts for those who want to start exploring.
Maybe @al3mart's suggestion here is worth adding, especially if we plan to deprecate the EVM template in favor of this one: #12 (review).
However, I’m not sure if it falls out of scope without a proper update to the documentation.
d81c05c to
ecb7855
Compare
Apologies, I remember excluding |
|
Can the merged branch be deleted? |
Uplift
asset-parachaintemplate to stable2409 - Release Changelog. Configure pallet-revive for the runtime. By default, ETH RPC is not configured.polkadot-sdk-parachain-templatetostable2409pop-nodetostable2409base-parachaintostable2409Status
node&runtimesuccessfully.pop-cli