feat: pop bench storage implementation

[chungquantin]

The PR implements the pop bench storage feature benchmark the storage speed of a chain snapshot. The implementation simply reuses the struct StorageCmd in frame-benchmarking-cli and read all arguments provided to pop bench storage with env::args().

Different from other commands pop bench pallet and pop bench overhead that requires runtime binary. This command requires a node binary built with runtime-benchmarks feature.

How to test the PR?

pop bench storage --state-version 1

[codecov]

Codecov Report

Attention: Patch coverage is 76.84211% with 44 lines in your changes missing coverage. Please review.

Project coverage is 75.44%. Comparing base (bca125b) to head (55bc9c0).
Report is 1 commits behind head on chungquantin/feat-pop_bench_command.

Files with missing lines	Patch %	Lines
crates/pop-cli/src/commands/bench/storage.rs	74.74%	7 Missing and 18 partials ⚠️
crates/pop-cli/src/common/builds.rs	82.25%	3 Missing and 8 partials ⚠️
crates/pop-parachains/src/bench/mod.rs	83.33%	2 Missing and 2 partials ⚠️
crates/pop-cli/src/commands/build/spec.rs	0.00%	2 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/bench/mod.rs	0.00%	1 Missing ⚠️

@@                           Coverage Diff                           @@
##           chungquantin/feat-pop_bench_command     #457      +/-   ##
=======================================================================
+ Coverage                                75.39%   75.44%   +0.05%     
=======================================================================
  Files                                       70       71       +1     
  Lines                                    15924    16083     +159     
  Branches                                 15924    16083     +159     
=======================================================================
+ Hits                                     12006    12134     +128     
- Misses                                    2353     2356       +3     
- Partials                                  1565     1593      +28     

Files with missing lines	Coverage Δ
crates/pop-cli/src/commands/bench/pallet.rs	72.78% <100.00%> (ø)
crates/pop-cli/src/commands/bench/mod.rs	0.00% <0.00%> (ø)
crates/pop-cli/src/commands/build/spec.rs	74.81% <0.00%> (+0.73%)	⬆️
crates/pop-parachains/src/bench/mod.rs	82.14% <83.33%> (-0.29%)	⬇️
crates/pop-cli/src/common/builds.rs	83.82% <82.25%> (-16.18%)	⬇️
crates/pop-cli/src/commands/bench/storage.rs	74.74% <74.74%> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AlexD10S]

Nice!! I have never used this feature before, pop makes it super easy to use now.

I left some comments. The only request is a simple one: adding profile as a CLI argument.

Another thing I noticed, when running pop bench storage --state-version 1 on a node that hasn’t been built with the --benchmark feature, I get:

 Failed to run storage benchmark: command ["/target/release/parachain-template-node", "benchmark", "storage", "--state-version", "1"] exited with code 1

Would it be possible to detect if the node wasn’t built and improve the error message? Not sure if this is easy to implement, so feel free to ignore it for now.

[chungquantin]

@AlexD10S

Would it be possible to detect if the node wasn’t built and improve the error message? Not sure if this is easy to implement, so feel free to ignore it for now.

I improved the code to throw direct error instead of the exit code.

[AlexD10S]

Great work! Thanks for improving the error message, it looks much better now. I left a minor comment, but I've approved it!