[Cocoa] Add handler for javascript prompt/input. #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyaby
force-pushed
the
prompt_handler_macos
branch
2 times, most recently
from
d4c31c3 to
a92e0be
Compare
|
Prompt works fine, but there is no Edit menu item. |
|
Like you tried it and you now get the prompt correctly but don't see Edit
up in the mac header bar (next to View)?
I'll double check I pushed everything correctly, and take a screenshot
…On Wed, Jan 8, 2025, 12:59 Roman ***@***.***> wrote:
Prompt works fine, but there is no Edit menu item.
—
Reply to this email directly, view it on GitHub
<#1567 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHUP2ROTNJRXZTLLSLVFPK32JWGUTAVCNFSM6AAAAABUWSL7CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYGY2TKMJYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Cocoa was missing handler for calling prompt("...")
This adds the popup and input handling
…erts, etc. The existing implementation in the keyDown_ handler only works on items in the main view and not in subviews/modals
|
This is the edit menu, up in the top bar: |
maddyaby
force-pushed
the
prompt_handler_macos
branch
from
a92e0be to
28dab57
Compare
|
rebased and updated |
r0x0r
pushed a commit
that referenced
this pull request
Feb 11, 2025
* [Cocoa] Add handler for javascript prompt/input.
Cocoa was missing handler for calling prompt("...")
This adds the popup and input handling
* [Cocoa] Add edit menu to get cut/copy/paste/selectAll on submenus, alerts, etc.
The existing implementation in the keyDown_ handler only works on items in the main view and not in subviews/modals
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cocoa was missing handler for calling prompt("...")
This adds the popup and input handling. It also adds the Edit menu item to handle cut/copy/paste for subviews and modals in addition to the main view