The window title bar background color adapts to the system theme #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0r
reviewed
Jan 27, 2025
| @@ -272,6 +275,21 @@ def __init__(self, window, cache_dir): | |||
| def __str__(self): | |||
| return f'<System.Windows.Forms object with {self.Handle} handle>' | |||
|
|
|||
| def get_system_theme(self): | |||
There was a problem hiding this comment.
To be more explicit this function could be named is_dark_theme and return True or False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the default window title bar of the Windows platform is fixed to white. I added a function to determine whether the system theme is dark or light, so that the title bar can adapt to the system theme.